From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KW/tB3SIjGoyID0AWB0awg (envelope-from ) for ; Mon, 24 Aug 2026 14:07:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fZzRzkfp; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1C81B1E033; Mon, 24 Aug 2026 14:07:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 775891E033 for ; Mon, 24 Aug 2026 14:07:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 49E614BB24CF for ; Mon, 24 Aug 2026 18:07:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 49E614BB24CF Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fZzRzkfp Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 5C3304BA9025 for ; Mon, 24 Aug 2026 18:07:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5C3304BA9025 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5C3304BA9025 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787594839; cv=none; b=olVgfB7QL5EQArlIpSs16MMFlC+5kWt0VGOUil2XRJiDcipusfojS+6BEdtd8U6YlXRBrBfZNn4tHibocNl9YmYAgYOS0NOBAZqOh4/PcAbi6FEV6A8wc4WzKua6OYdkn1xhZxnD3OPeudLL8q0Gt48I02uQHa7HSiOKCvrSoe0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787594839; c=relaxed/simple; bh=rbPIWA1qCVC+fsqLoNHT7SUtKMvE6wgLr0Tw3ix1LZI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=aDbkLcfOqCA2d5PrNRcegihoQbKllM+BFTQCPE4sA8z7jKVCaYKjG0/JfbQrEy6m+k0ECQx9Aa7CgJ924CdkyHqLeKbJjL2Dsd98Ca8XfYvu7BPePzzmwcHokazSwgcIP0Y71rS+Ek8rW9rYE6ut3cvgvCfrYKdYXSVCO9g3kYI= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fZzRzkfp DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C3304BA9025 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787594838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nO7mlz2Jk9WVJuwKPNxuW9Bgl4OGUVOMD+5F5QHGkWU=; b=fZzRzkfpVo2IO4hCnCu0e5xywDQ1y4kkS5ELQP2/Q5/KKtVGojRQCR6bamjR2INjd0NUTR R9QsqnhsLzdClSkh1i1oUwZo0Iwn6OaBTMbr2LLemNN4LEoClq25jHRnhTLpNAlfUDTH2R rHsEwFei9XpM2NYpmcmHG1nipFWst6s= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-dpRBeydiPTKe_cPBP4icZQ-1; Mon, 24 Aug 2026 14:07:15 -0400 X-MC-Unique: dpRBeydiPTKe_cPBP4icZQ-1 X-Mimecast-MFC-AGG-ID: dpRBeydiPTKe_cPBP4icZQ_1787594834 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-473ac08a6a4so2358979f8f.0 for ; Mon, 24 Aug 2026 11:07:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787594834; x=1788199634; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=nO7mlz2Jk9WVJuwKPNxuW9Bgl4OGUVOMD+5F5QHGkWU=; b=WymWTYhubdx7mz3zVxywJpeo8rYQxht/eskw3d0GJ3xIz0fDQzWqTlR9HIJc/GnlDL tV82seFTQdf+C3rTW7O433DM3IBeca23X8mXOMGapSn+Ft79rwU/HejBij5ts2ztUExC KNu56wfK39Zn6jVGcd71L2arIhPaEaS0/kdJ1O+TOxCuHKtV51s9RMVw47LRW/F+V7lY TIAVWgPbpdMvd6mqhY+utQUFz8h9QbpgRsasJPp31O+mS4rBMJMYzzOqKGYVXLxMzUJ2 EN1DiFLQmMymkP5pjckn97clJuJR3P3nsZio22BPQZpjIvom0Jpbo9yED6SNKwlwzUNm Evyg== X-Gm-Message-State: AFuF++m7o5DYOEMLtyZBKGOoLcRuygh7d5Ju5FZxevJBAx3rJCshz73x UPpMPAPAdVKTEzs2/9cIvI9ez0kndRVExBPq6jeAEnm0S6XwBLkDtxqyBMlZdORIeloyEx9xGCT 63hEKo1MnfnBOBVaHMjWFMeS5kui6Dct5xg3wD2oNyTs0droCikBf9vSdA2ODTDc= X-Gm-Gg: AR+sD13LzIFBznLoDXgGPTgFF0sHmklpZClW5ISZVE7sslkbD62xQcYORlh8Q8S0aI5 Pnme4MGp1/4FU9qBDdnqK+Oiu8+u5KSlcllDv/ZFd0YMCO0Dho/0JeW26aB+/0HHfZOhLWn/Nis bgf53Rm49OJfzXmry7Lc4nur6lD4e3V5AdgOlFiDdXXrmJf0qyemNaPRKHR7vTc6hK+pCPVg/AC X4LRKEdo7ZnqPuoR+NPGCVjCwAoM7YlUgHZizNVVcuhF2chH1H0B76Z5a08H1PmfCDiMpXbpJib HrodI6rIyiDkHVknCKhKGB4H5msNMMFOoNBiHE4ZUiqkd8cLCdZPZEBg5uzO40Hnki/1iCWZ6k8 Fc6i+ZZB47B9+wKbiEX2WzlaqhMw= X-Received: by 2002:a05:6000:400a:b0:481:5276:e4e3 with SMTP id ffacd0b85a97d-482c81ca534mr23456128f8f.19.1787594833981; Mon, 24 Aug 2026 11:07:13 -0700 (PDT) X-Received: by 2002:a05:6000:400a:b0:481:5276:e4e3 with SMTP id ffacd0b85a97d-482c81ca534mr23456060f8f.19.1787594833597; Mon, 24 Aug 2026 11:07:13 -0700 (PDT) Received: from localhost (128.223.159.143.dyn.plus.net. [143.159.223.128]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482c9b69a49sm8805394f8f.7.2026.08.24.11.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 11:07:13 -0700 (PDT) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org, Tom de Vries Subject: Re: [PATCH] gdb: track parents of nameless DIEs in cooked indexer In-Reply-To: <87ecfrqtlr.fsf@tromey.com> References: <4c16f81081452e05f47741be7a2d15a250827c52.1787152777.git.aburgess@redhat.com> <87ecfrqtlr.fsf@tromey.com> Date: Mon, 24 Aug 2026 19:07:12 +0100 Message-ID: <87se43tmsv.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BE48nb8GeUhPPGKKmenvKmhOwU0Aw11W6GaV_TDLRlQ_1787594834 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> I found this patch while looking at PR gdb/33447, Tom Tromey had > Andrew> suggest this patch might fix that bug, so I took the patch from the > Andrew> mailing list, rebased it to current HEAD, checked the test still > Andrew> passed, and then checked to see if it fixed PR gdb/33447. > > Thanks for resurrecting this. I should have reviewed it ages ago. > > Andrew> + else if (this_parent_entry != nullptr) > Andrew> + { > Andrew> + /* Record this DIE's parent in the map so that deferred > Andrew> + parent lookups through DW_AT_specification chains can > Andrew> + find the parent even for DIEs that have no name and thus > Andrew> + no cooked_index_entry. */ > > I just really, truly loathe this part of DWARF. > > Approved-By: Tom Tromey Pushed. Thanks, Andrew