From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KnAVMLN4vmoVLyQAWB0awg (envelope-from ) for ; Thu, 01 Oct 2026 11:13:55 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Epa5dyFZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AD1FE1E01F; Thu, 01 Oct 2026 11:13:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 264AC1E01F for ; Thu, 01 Oct 2026 11:13:54 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B025A4BA79B6 for ; Thu, 1 Oct 2026 15:13:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B025A4BA79B6 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Epa5dyFZ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 64A1E4B920EC for ; Thu, 1 Oct 2026 15:13:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 64A1E4B920EC Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 64A1E4B920EC Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790867608; cv=none; b=ZimFMVxA7p2W3eI1WtjfpvNRvvx6ZSOiNoVJ6KmQMzJqsgg0eVmbsWq/lHH5bMNOwZko/At28nilGJks3F4nZEQ7gbEWbYgPsS+NaiDvI2+dsXtxHqskPfaNyRb/ljvricflJ2WHQiHS56s2XnoCWtsrxPlEIXVa/xwwOxqPr8Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790867608; c=relaxed/simple; bh=Nvyd5mfAqft0tmYjVvktKVe/5djINe1kEZc6wVHOuYI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=RVhyPbaCpNlDUojvUhirfi6+RIiftHONj5qYzc+ZeCiTvac+okmtx5kqhsI1ZL7Zz0mmg5hFxAC4txuXZndaXA9Tkekmoe+xTBI82Cm7fRuUO8X5F6xZVAuFGIHgzzFC7CrwpeJZonxMt3m78Dm11xBHOZ844NhHyj8Z8PX5R2Y= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Epa5dyFZ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 64A1E4B920EC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790867608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E8A/tB6BsPpfNmwQUZfjbpBwquaHf0G7JJMFqX+uuHw=; b=Epa5dyFZoBF1ELnZu39+PDMAdF6d3LFb2OCDNB8kIyKbSAb1lAXaPDmU8VvIRmNq7f7CsA 5XX31ddB/N4C2HuHTMWPdtcw2HIyShW9JRHAXe9GjoqF3dn09mSg4kOAAeoFRQeNVx0sQw TbbAYSMuEQ6Vbsf04/YlPZgj0Q4XLT0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-131-lTpifl-tP-eriXDhIVG7pA-1; Thu, 01 Oct 2026 11:13:26 -0400 X-MC-Unique: lTpifl-tP-eriXDhIVG7pA-1 X-Mimecast-MFC-AGG-ID: lTpifl-tP-eriXDhIVG7pA_1790867606 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4a0023f2b97so26264825e9.2 for ; Thu, 01 Oct 2026 08:13:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790867605; x=1791472405; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=E8A/tB6BsPpfNmwQUZfjbpBwquaHf0G7JJMFqX+uuHw=; b=DLAAUDKfZy0KZ98eyMykGI9+bN1n+YJHgOjuLxUZgJ7Zxulk++Hhs/JUSS8penIDHf P68EGIo4LWdlLn85iCIN8uvEdT6BWNyB1TIvECTbloffuuymjJs/gNQZc8bt4WJOo8FX 7yN+nRj8V1Tcpzy4WIlk/nnJE91F1UWlJDit381lVm/r6XONqlpedfUzK7AIkloWn8vU ymmAd1GI+1C/sME/6bwUWIpsHp1DBpHtq6ub81qOJShVapmxBmQbsZmYv0T3A4zW1AIV mSkZWiNRbEHqmXjKFvkIzWHOaBk6wMaQnz/RZVe8K+0BtKwI8pPb9aAU1wlTrTeLZmjb 37hg== X-Forwarded-Encrypted: i=1; AKwUvBxWmOyg2duCbcjh93IiV4l9qK5PCya8ISl8KK9U+Fm5ZyFEY0LxO8saRLMyAmzSFyRspLPgSCDEQ503ow==@sourceware.org X-Gm-Message-State: AFuF++kcZGc9kyY4Th3hO6IZoXIUh7XNcSKEterati3tfultsfSx8gCt 2XCbp+ts8JOmSBRQalvYDLu7ajN0UH/6YQvAzPS5o4pMELcPCC6PoAoZEqUj2SLi9jvaB+3Z/sH Ii67QG7xbyslz8pz8bSZNOER07s1iV3ooen8iQD4ROEBvH4j84IBooCrZVxvzIePjaLH94dk= X-Gm-Gg: AYBFou2EJYYcLchO+5Yr5xXZKKamn6TS0s1E2LfnhxcZ2eSyajQknJXHlbLUzgvSP7B cfzvAsU6WKSaxnWmrTj7xd7Z/60dOTWfR5i5Yy+/lvBa9kZrHZVCfb55TE9uCqKmo+xtaiHd0cN NVesBXfwWRXeyzSpM+hx+4M2wc/olyuK0S6XK239C7+uVDrrtiMt+iNO9h1qtS24tJXlxqZhcOp 58nner1ByXsMq9fiO/fu44f6Riyjay0QvyPmMVj3ynyiL5KRQSX4WC/xF5CnGebsS+bj7mZv8K+ wrjiM+8hQVWfQ3W8Mq2tQTmEPtiAxcxvsmjYnO8KstlMxbAnHmnZuljzw3Crs7NkyYMp X-Received: by 2002:a05:600c:1c28:b0:4a0:1aa0:7cfa with SMTP id 5b1f17b1804b1-4a01afec062mr97972855e9.12.1790867605273; Thu, 01 Oct 2026 08:13:25 -0700 (PDT) X-Received: by 2002:a05:600c:1c28:b0:4a0:1aa0:7cfa with SMTP id 5b1f17b1804b1-4a01afec062mr97972475e9.12.1790867604863; Thu, 01 Oct 2026 08:13:24 -0700 (PDT) Received: from localhost ([213.31.44.29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a02726513asm2686215e9.5.2026.10.01.08.13.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2026 08:13:24 -0700 (PDT) From: Andrew Burgess To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH v2 08/11] gdb: update comments of global_symbol_searcher::expand_symtabs In-Reply-To: <20261001020952.698419-9-simon.marchi@polymtl.ca> References: <20260929194119.155169-1-simon.marchi@efficios.com> <20261001020952.698419-9-simon.marchi@polymtl.ca> Date: Thu, 01 Oct 2026 16:13:23 +0100 Message-ID: <87se2pxxm4.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2BLRcO4tOVE1eTW3M9oC3b11ZTvOvsH6d_FvQcD4no0_1790867606 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org simon.marchi@polymtl.ca writes: > From: Simon Marchi > > Update the doc comment of expand_symtabs to describe more accurately what > the return value means. It is true when a matching function msymbol for > which no debug info exists is found. > > Update a comment inside expand_symtabs: > > - remove "unconditionally", because it's not quite true > - use "for variables" instead of "for SEARCH_VAR_DOMAIN". LGTM. Approved-By: Andrew Burgess Thanks, Andrew