From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WVJwEg3Z2Gq40QQAWB0awg (envelope-from ) for ; Wed, 21 Oct 2026 11:23:57 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=N1g4dD4H; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3FC481E051; Wed, 21 Oct 2026 11:23:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A07441E04D for ; Wed, 21 Oct 2026 11:23:56 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 352D24BA79B8 for ; Wed, 21 Oct 2026 15:23:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 352D24BA79B8 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=N1g4dD4H Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 3FF5B4BA79A5 for ; Wed, 21 Oct 2026 15:22:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3FF5B4BA79A5 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3FF5B4BA79A5 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792596169; cv=none; b=N4OD1ZXcq9Tu/Eil4ZeL/T/AtQys8qKYSllU3ljz1xgZlQWwe7tM+0vFhQUtOjVnKTQ4AS+UKlcVyju2HZo2hE9R0hgol1i47903ON9c9dqOwqcaUfGwNmH9F7w6757ro9/DJXhJ0izsPEiH0W/MYz18Zl9Rh1xaV7KyD04j2QM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792596169; c=relaxed/simple; bh=VJwjGFD/363boLfFl1od9ApVpFxjWgK3f5GgYIxPL9A=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=fIBP4tKnsTwGbNRKCI3XHNh7V35NKOrMxv6c4FgzUJKwCrckp8Vrm+PmXyF/nDOSlukcXj41Gw9ae7a/hApGuQsLNl3y+hkFTtNafOZmzOn1kE8rJhnLqdhVqQfMMdqLDWvhVeOx4FrC32ohW2NAz9hCzjPgN3IJu4zvL2IyItY= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=N1g4dD4H reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3FF5B4BA79A5 Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id JT75xWawGv0ndJY9RxXPl5; Wed, 21 Oct 2026 15:22:49 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id JY9QxwNjKRC6eJY9QxMZRR; Wed, 21 Oct 2026 15:22:48 +0000 X-Authority-Analysis: v=2.4 cv=FvsF/3rq c=1 sm=1 tr=0 ts=6ad8d8c8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=UbZPRHdEtNaZsFXasLgA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VJwjGFD/363boLfFl1od9ApVpFxjWgK3f5GgYIxPL9A=; b=N1g4dD4HUJLpjCbJV00xCPzkW+ /q+ihMzqYonjeZyj6oN/hzwzVQsBbgZgoV06agrUdqiJeakOVyjlQv2DkiNQi0mFzXAjEVTSVg+ZJ d3G2kgDydjRVPzUai2WA6Ftq7; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:49232 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xJY9P-00000001WKT-2lPS; Wed, 21 Oct 2026 09:22:47 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH 07/13] gdb: extract lex_char_literal from cpname_yylex In-Reply-To: <20261020162054.2140671-8-simon.marchi@efficios.com> (Simon Marchi's message of "Tue, 20 Oct 2026 12:17:29 -0400") References: <20261020162054.2140671-1-simon.marchi@efficios.com> <20261020162054.2140671-8-simon.marchi@efficios.com> X-Attribution: Tom Date: Wed, 21 Oct 2026 09:22:46 -0600 Message-ID: <87se1zyt6h.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xJY9P-00000001WKT-2lPS X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net (bapiya) [97.122.110.129]:49232 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOUXVYAbu+co2tFuGSvT1I1GhDmYKF0XZ8Nffr0g+Yi1WTl7737Ue1x0WX6WxHdvoUOXkXZkxbVaSLF+uTi/H2Tk3SOuDJzmt5aHA3s9+pfCU7OpCMNl QjUymjG452HjfBPzhsILT6me8TcpVLzKpyig0mHpGXcAuA4BRTgS/8tak47V4cqbHnVM7QwOS14oBFcEBN7AnxcsVsbjHnB+4fg= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> The comment mentioned that a quote could also start a quoted symbol Simon> reference, like 'foo(int,int)', but this code doesn't seem handle that, it Simon> really just handles character constants, so drop that part of the comment. This is probably some ancient copy-paste from the C parser. Tom