From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id JLKuBA0j2WqClQgAWB0awg (envelope-from ) for ; Wed, 21 Oct 2026 16:39:41 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=O4CPaMhU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D802D1E04D; Wed, 21 Oct 2026 16:39:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D3B6F1E04D for ; Wed, 21 Oct 2026 16:39:39 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 59DE64BA23E5 for ; Wed, 21 Oct 2026 20:39:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 59DE64BA23E5 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=O4CPaMhU Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 8EA314BA2E1F for ; Wed, 21 Oct 2026 20:39:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8EA314BA2E1F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8EA314BA2E1F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792615147; cv=none; b=AtPFv7kVVm7/6LQO9Er6GPG3gjZoQby/Csw2/J8ZRS8S3VXc9p5l5/kajcMgD/pGY6Ik2nsXKDHcmPQHlyKeWlA6kSYciH5aDUaBW8teCZWwR0Sy9Ppe8prsODb8OUeO/kEQTqq+z9F6k7dw8V+6A6B4W5Aov7pYO3BKBWY4zlw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792615147; c=relaxed/simple; bh=fg9Iduwsm2YsEI51FmHrbuLTIZObPLvzcYgUYARgnQ0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=AWeHxks3/81N1WATK9/6QESOGXbux5eozUAXfNPvweE3XWpRwAYWx+gTrSHqM0VTHMLlSOIm5gUgq4Lxu775Sc8/KzMGLQDJCdPZexgTN+mUe9MMWOJ0JHZlTXk+9R/9uqnv55MThj+J/At3cyulbFpQK2iUbp6Do6Pb8x57cSg= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=O4CPaMhU reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8EA314BA2E1F Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id JIoOxM8rnusRSJd5WxHkiQ; Wed, 21 Oct 2026 20:39:06 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Jd5VxHQFEirxPJd5Vxtlxt; Wed, 21 Oct 2026 20:39:05 +0000 X-Authority-Analysis: v=2.4 cv=FqoF/3rq c=1 sm=1 tr=0 ts=6ad922ea a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=JYGTrjrC5MDwC52l4G0A:9 a=zZCYzV9kfG8A:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PjQsB1eZrOS+oXOF2AxemUBFuGqZJTxEmsnzxgw+fkw=; b=O4CPaMhUk6rXPgSIBl1VEKEnDh YCtOYwenSA4e/GvxtSGgrjRcAngmSjA2bbRyDcsjehm/iiLWmQSSZfk6sAUs9SG7m1iTebSY7YImB k9AoiAU7Jd52oqeLF80KPtiRK; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:56376 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xJd5U-000000038kV-2l0m; Wed, 21 Oct 2026 14:39:04 -0600 From: Tom Tromey To: Abdul Basit Ijaz Cc: gdb-patches@sourceware.org, JiniSusan.George@amd.com, tom@tromey.com, eliz@gnu.org, Nils-Christian Kempke Subject: Re: [PATCH v11 03/10] gdb: handle stepping through functions with DW_AT_trampoline In-Reply-To: <20260803193449.33375-4-abdul.b.ijaz@intel.com> (Abdul Basit Ijaz's message of "Mon, 3 Aug 2026 21:34:42 +0200") References: <20260803193449.33375-1-abdul.b.ijaz@intel.com> <20260803193449.33375-4-abdul.b.ijaz@intel.com> X-Attribution: Tom Date: Wed, 21 Oct 2026 14:39:03 -0600 Message-ID: <87se1yu6u0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xJd5U-000000038kV-2l0m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net (bapiya) [97.122.110.129]:56376 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDzVNRTBf9xyittxyQE3fM16+rdINJRiQDd3PBYFN3foOFnFQWpnV1p55qbQyFI3FDx2RfagTpq/y+Y4f+gcuEOrwgktHPNk1KE874TUD6CUJGgkH8ss ZfrmbKgYepAo1+2PnZWv2sPsVr18vDyZIH+aALRDWJ9JyajApBL/DKDRUtKiX/7V13b/neubht/U5XR5pQr8TlfpVT7an5KbIbI= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Abdul Basit Ijaz writes: > This patch makes infrun continue stepping into and through trampoline > functions marked via the DW_AT_trampoline in DWARF. I'm probably not the best person to review this but I did have one question: > diff --git a/gdb/infrun.h b/gdb/infrun.h > index cbc603b74ed..135d1fc350b 100644 > --- a/gdb/infrun.h > +++ b/gdb/infrun.h > +/* Maximum size of trampoline chain to process while resolving > + trampolines. This avoids infinite loops for malformed debug > + information. */ > +#define MAX_TRAMPOLINE_CHAIN_SIZE 10 Are there cases where there may be multiple trampolines chained together? If it's unusual or pathological then I guess some hard-coded limit seems fine. If it's normal then why 10? Like, I'm wondering if perhaps some other approach should be taken. Tom