From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26271 invoked by alias); 17 Apr 2012 17:37:20 -0000 Received: (qmail 26193 invoked by uid 22791); 17 Apr 2012 17:37:18 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Apr 2012 17:37:05 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3HHb4IJ004781 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 17 Apr 2012 13:37:04 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3HHb3vx025792 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 17 Apr 2012 13:37:03 -0400 From: Tom Tromey To: Phil Muldoon Cc: Siva Chandra , gdb-patches@sourceware.org Subject: Re: [RFC - Python scripting] New methods Symtab.global_block and Symtab.static_block (docs included) References: <4F8D6779.8090906@redhat.com> Date: Tue, 17 Apr 2012 17:41:00 -0000 In-Reply-To: <4F8D6779.8090906@redhat.com> (Phil Muldoon's message of "Tue, 17 Apr 2012 13:52:09 +0100") Message-ID: <87r4vmtg3k.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00506.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> We already have gdb.Block.is_static and gdb.Block.is_global. I don't Phil> have an objection to this patch per-se, but wouldn't the user acquire Phil> the global/static blocks similarly by iterating the blocks in the Phil> Python code and doing the above tests? He wants to be able to iterate over the blocks in a symtab. Right now there is no way to do this, since there's no way to get a good starting point. So, these methods provide that access. They are complementary to the methods on Block. Phil> gdb.python/ prefix to filenames here. Oh yeah, I missed that one. Thanks. >> + block = symtab->blockvector->block[GLOBAL_BLOCK]; >> + return block_to_block_object (block, symtab->objfile); Phil> I don't think so, but can block ever be NULL here? I don't think so. Phil> However, blpy_get_superblock has a NULL block check, so it might Phil> be worthwhile checking it out. I think that is different because the global block's superblock is NULL. >> + block = symtab->blockvector->block[STATIC_BLOCK]; >> + return block_to_block_object (block, symtab->objfile); Phil> Same as above. Ditto. Tom