From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21390 invoked by alias); 10 Jul 2012 16:49:15 -0000 Received: (qmail 21381 invoked by uid 22791); 10 Jul 2012 16:49:14 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SARE_SUB_IMPROVE,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Jul 2012 16:48:57 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6AGmufH011194 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 Jul 2012 12:48:56 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6AGmttt008391 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 10 Jul 2012 12:48:56 -0400 From: Tom Tromey To: dje@google.com (Doug Evans) Cc: gdb-patches@sourceware.org Subject: Re: [RFA 2/4] Improve DWARF Type Unit performance References: <20120710080913.82E3B1E1253@ruffy2.mtv.corp.google.com> Date: Tue, 10 Jul 2012 16:49:00 -0000 In-Reply-To: <20120710080913.82E3B1E1253@ruffy2.mtv.corp.google.com> (Doug Evans's message of "Tue, 10 Jul 2012 01:09:13 -0700 (PDT)") Message-ID: <87r4sjh894.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00134.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> 2012-07-09 Doug Evans Doug> * psympriv.h (struct partial_symtab): New member "anonymous". Doug> * psymtab.c (partial_map_symtabs_matching_filename): Ignore Doug> anonymous psymtabs. Doug> (map_symbol_filenames_psymtab): Ditto. Doug> (expand_symtabs_matching_via_partial): Ditto. Doug> (dump_psymtab): Update. Does read_psymtabs_with_filename need to check 'anonymous'? It wasn't clear to me. Other that that, this patch looks good to me. Tom