From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19591 invoked by alias); 12 Sep 2012 14:26:07 -0000 Received: (qmail 19575 invoked by uid 22791); 12 Sep 2012 14:26:06 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Sep 2012 14:25:53 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8CEPrQm031413 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Sep 2012 10:25:53 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8CEPqQ5002777 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 12 Sep 2012 10:25:52 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [3/3] RFC - optional patch to restore DW_AT_data_member_location References: <87628cfbg2.fsf@fleche.redhat.com> <20120826081205.GB29056@host2.jankratochvil.net> <87zk4w6zys.fsf@fleche.redhat.com> <20120912132520.GA2130@host2.jankratochvil.net> Date: Wed, 12 Sep 2012 14:26:00 -0000 In-Reply-To: <20120912132520.GA2130@host2.jankratochvil.net> (Jan Kratochvil's message of "Wed, 12 Sep 2012 15:25:20 +0200") Message-ID: <87r4q771xr.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00201.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> I see I did not make clear why I like the reproducibility of the Jan> compilation. This is because sometimes it is good to know what was Jan> hand-edited in the file and I find a bit excessive to keep both the Jan> original and the hand-edited .S files in the repository due to it. Jan> This is why I sometimes did #if 0-#else-#endif or #if 0-#endif-#if Jan> 1-#endif constructs in the .S files (I see it now only in Jan> gdb.dwarf2/dw2-const.S). Ok. Jan> I sure do not insist on anything like that, just FYI. I'll at least add some comments to the .S. I suppose this is another way that having a DWARF assembler would be preferable. Tom