Re: [PATCH 3/3] Add a test case for the jit-reader interface.

Jan Kratochvil
2012-12-10T16:38:22Z

On Fri, 07 Dec 2012 10:14:45 +0100, Sanjoy Das wrote:
> > I do not understand why you do not use gdb/jit.h here? This file is
> > a duplicate. Sorry if it was already discussed during initial JIT review.
>
> I don't think this has been discussed, but my justification is that
> we'd want the JIT tests to break if we make ABI incompatible changes
> to the structures in jit.h (which, loosely speaking, are part of GDB's
> "interface").

OK, that makes sense. But in such case please make there a clear separate
jit.h copy (with a different name and some added #ifdef/#error or something
like that protection so that if one mistakenly includes gdb/jit.h it gets
error-reported, with an explanation you made to me now above).

> As an aside, something seems to have gone wrong with my SSH keys and I
> was wondering if someone could commit my work (patches attached) for
> me, if that is permissible.

While I can commit it for you I find it would be better to contact
<overseers at sourceware.org>. Still contact me off-list if you do want to
commit it by myself (it is OK, it is commonly done).

Thanks,
Jan