Re: [PATCH 3/3] Add a test case for the jit-reader interface.

Pedro Alves
2012-10-17T16:16:00Z

On 10/16/2012 09:15 PM, Tom Tromey wrote:
>>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:
>
> Sanjoy> +2012-10-08 Sanjoy Das <sanjoy@playingwithpointers.com>
> Sanjoy> +
> Sanjoy> + * gdb.base/jit-reader.exp: New file. Test case for the jit-reader
> Sanjoy> + interface.
> Sanjoy> + * gdb.base/jithost.c: Do.
> Sanjoy> + * gdb.base/jithost.h: Do.
> Sanjoy> + * gdb.base/jitreader.c : Do.
>
> Thanks very much for doing this.
>
> I was concerned that this test should be native-only, but then I noticed
> that skip_shlib_tests checks isnative. So, no worries there.

Hmm, confused. :-)

# Return a 1 if we should skip shared library tests.

proc skip_shlib_tests {} {
# Run the shared library tests on native systems.
if {[isnative]} {
return 0
}

This means that shlib tests are never skipped on native, but
it doesn't prevent it from running elsewhere.

Should the test be native-only? If so, why? Doesn't the jit interface work
when debugging with remote targets (e.g., gdbserver)?

>
> Sanjoy> +set include_dir ${objdir}/../../
>
> I think this should use standard_output_file.
>
> This patch is ok with this change.

--
Pedro Alves