Re: [PATCH 3/3] Add a test case for the jit-reader interface.

Jan Kratochvil
2013-01-14T03:52:21Z

On Sun, 13 Jan 2013 22:57:34 +0100, Sanjoy Das wrote:
> 2. Use SLASH_STRING instead of a raw backslash when computing the full
> path of a plugin (in the second patch).

I have considered it pre-approved for a commit with the few changes.

But I see you can improve:
+ so_name = xstrprintf ("%s%s%s", SLASH_STRING, jit_reader_dir, args);
->
+ so_name = xstrprintf ("%s" SLASH_STRING "%s", jit_reader_dir, args);

So the patchset is approved again with this change.

Thanks,
Jan