From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30778 invoked by alias); 28 Nov 2012 21:30:15 -0000 Received: (qmail 30680 invoked by uid 22791); 28 Nov 2012 21:30:11 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_RV,TW_TR,TW_XS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Nov 2012 21:30:01 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qASLU1xn003073 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 28 Nov 2012 16:30:01 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qASLU0cT024570 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 28 Nov 2012 16:30:00 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Subject: RFC: remove xasprintf Date: Wed, 28 Nov 2012 21:30:00 -0000 Message-ID: <87r4nd8lgo.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00830.txt.bz2 This patch removes xasprintf and xvasprintf. I believe we had agreed not to use them any more, and I don't see any uses in the tree any more. Tested by rebuilding and grep. Tom 2012-11-28 Tom Tromey * common/common-utils.c (xasprintf, xvasprintf): Remove. * common/common-utils.h (xasprintf, xvasprintf): Remove. diff --git a/gdb/common/common-utils.c b/gdb/common/common-utils.c index ad01ed6..ef5d638 100644 --- a/gdb/common/common-utils.c +++ b/gdb/common/common-utils.c @@ -137,22 +137,6 @@ xstrvprintf (const char *format, va_list ap) return ret; } -void -xasprintf (char **ret, const char *format, ...) -{ - va_list args; - - va_start (args, format); - (*ret) = xstrvprintf (format, args); - va_end (args); -} - -void -xvasprintf (char **ret, const char *format, va_list ap) -{ - (*ret) = xstrvprintf (format, ap); -} - int xsnprintf (char *str, size_t size, const char *format, ...) { diff --git a/gdb/common/common-utils.h b/gdb/common/common-utils.h index 030bcc5..58fa3f9 100644 --- a/gdb/common/common-utils.h +++ b/gdb/common/common-utils.h @@ -43,13 +43,6 @@ char *xstrprintf (const char *format, ...) ATTRIBUTE_PRINTF (1, 2); char *xstrvprintf (const char *format, va_list ap) ATTRIBUTE_PRINTF (1, 0); -/* Like asprintf/vasprintf but get an internal_error if the call - fails. */ -void xasprintf (char **ret, const char *format, ...) - ATTRIBUTE_PRINTF (2, 3); -void xvasprintf (char **ret, const char *format, va_list ap) - ATTRIBUTE_PRINTF (2, 0); - /* Like snprintf, but throw an error if the output buffer is too small. */ int xsnprintf (char *str, size_t size, const char *format, ...) ATTRIBUTE_PRINTF (3, 4);