From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23726 invoked by alias); 18 Dec 2012 16:40:49 -0000 Received: (qmail 23596 invoked by uid 22791); 18 Dec 2012 16:40:47 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 16:40:01 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBIGdx3x003795 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 18 Dec 2012 11:39:59 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qBIGdwsp026049 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 18 Dec 2012 11:39:58 -0500 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit 2/2] Import gnulib's errno module. References: <1355756839-11337-1-git-send-email-brobecker@adacore.com> <1355756839-11337-2-git-send-email-brobecker@adacore.com> <20121218060719.GD3273@adacore.com> Date: Tue, 18 Dec 2012 16:40:00 -0000 In-Reply-To: <20121218060719.GD3273@adacore.com> (Joel Brobecker's message of "Tue, 18 Dec 2012 10:07:19 +0400") Message-ID: <87r4mns49t.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00640.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> This module is needed in order to build GDBserver on ppc-lynx178, Joel> because the system does not define EILSEQ. I had a vague memory of some other errno defines, so I grepped and I found this in charset.c: /* Some systems don't have EILSEQ, so we define it here, but not as EINVAL, because callers of `iconv' want to distinguish EINVAL and EILSEQ. This is what iconv.h from libiconv does as well. Note that wchar.h may also define EILSEQ, so this needs to be after we include wchar.h, which happens in defs.h through gdb_wchar.h. */ #ifndef EILSEQ #define EILSEQ ENOENT #endif My first thought was that we can now get rid of this define. But now I wonder whether this define will cause problems if we also use libiconv; unless maybe the various header files are included in the right order. Tom