From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15582 invoked by alias); 19 Apr 2013 14:38:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15572 invoked by uid 89); 19 Apr 2013 14:38:54 -0000 X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 19 Apr 2013 14:38:54 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3JEcrHX002442 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Apr 2013 10:38:53 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3JEcqje002678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 19 Apr 2013 10:38:52 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 19/28] add missing decref in py-param.c References: <87ehe638ww.fsf@fleche.redhat.com> Date: Fri, 19 Apr 2013 16:20:00 -0000 In-Reply-To: <87ehe638ww.fsf@fleche.redhat.com> (Tom Tromey's message of "Fri, 19 Apr 2013 08:13:51 -0600") Message-ID: <87r4i6y48z.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00602.txt.bz2 The checker found a missing decref in compute_enum_values. * python/py-param.c (compute_enum_values): Decref 'item'. --- gdb/python/py-param.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gdb/python/py-param.c b/gdb/python/py-param.c index 2cc17b6..fbd9a77 100644 --- a/gdb/python/py-param.c +++ b/gdb/python/py-param.c @@ -611,12 +611,14 @@ compute_enum_values (parmpy_object *self, PyObject *enum_values) } if (! gdbpy_is_string (item)) { + Py_DECREF (item); do_cleanups (back_to); PyErr_SetString (PyExc_RuntimeError, _("The enumeration item not a string.")); return 0; } self->enumeration[i] = python_string_to_host_string (item); + Py_DECREF (item); if (self->enumeration[i] == NULL) { do_cleanups (back_to); -- 1.8.1.4