From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-103340-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18602 invoked by alias); 10 Jul 2013 17:03:01 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 18562 invoked by uid 89); 10 Jul 2013 17:02:58 -0000
X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 10 Jul 2013 17:02:58 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6AH2tf6032100	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 10 Jul 2013 13:02:55 -0400
Received: from barimba (ovpn-113-131.phx2.redhat.com [10.3.113.131])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6AH2q4k005655	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 10 Jul 2013 13:02:54 -0400
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix PR 15692 -dprintf-insert does not accept double quotes
References: <CANFwon1gnBtdU2jbrZ9bCVuF3dMPAY2syeB1oMBXE1x4PSDLNA@mail.gmail.com>	<51D2E749.9020604@codesourcery.com>	<CANFwon34nGekzdhGMA4=-0_1n_5CQ2jnxeq8bo8SjLU5e4wP-g@mail.gmail.com>	<51D4030F.6070000@codesourcery.com>	<CANFwon23=5E8DH4KHK0jMU+ZP33DtEzZNFQpYOQDzUq+oo80QQ@mail.gmail.com>	<51D42272.20209@codesourcery.com>	<CANFwon0GvGudzY2=LuROho=kSWY7bjv0dPE=GxZWjmhOrtC1xQ@mail.gmail.com>
Date: Wed, 10 Jul 2013 17:03:00 -0000
In-Reply-To: <CANFwon0GvGudzY2=LuROho=kSWY7bjv0dPE=GxZWjmhOrtC1xQ@mail.gmail.com>	(Hui Zhu's message of "Sun, 7 Jul 2013 13:53:35 +0800")
Message-ID: <87r4f6gxfn.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-07/txt/msg00280.txt.bz2

>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Hui> +	if { $args == "call" || $args == "fprintf" } {
Hui> +	    set foobarbazqux "\"foobarbazqux\""
Hui> +	} else {
Hui> +	    set foobarbazqux "\\\\\"foobarbazqux\\\\\""
Hui> +	}

Why are different regexps needed for these cases?
I thought the output was supposed to be the same in all situations.

Other than this issue the patch is ok.

Tom