From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17000 invoked by alias); 10 Jul 2013 17:47:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16989 invoked by uid 89); 10 Jul 2013 17:47:39 -0000 X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 10 Jul 2013 17:47:39 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6AHlWeA032026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 10 Jul 2013 13:47:33 -0400 Received: from barimba (ovpn-113-131.phx2.redhat.com [10.3.113.131]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r6AHlUaY000721 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 10 Jul 2013 13:47:31 -0400 From: Tom Tromey To: Raunaq 12 Cc: gdb-patches@sourceware.org, brobecker@adacore.com Subject: Re: [PATCH 3/5] powerpc64-aix inf-ptrace patch References: Date: Wed, 10 Jul 2013 17:47:00 -0000 In-Reply-To: (Raunaq's message of "Wed, 10 Jul 2013 14:44:12 +0530") Message-ID: <87r4f6fgst.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00287.txt.bz2 >>>>> ">" == Raunaq 12 writes: >> Since that is not the right way to go about it, I thought it would be >> better to create a new file called 'inf-ptrace64.c' derived from >> inf-ptrace instead, This new file contains all these above mentioned >> changes. inf-ptrace64 will be compiled only if the host is detected >> as powerpc64-ibm-aix. SO, it will not interfere with the original >> inf-ptrace that is used if host is powerpc-ibm-aix No, copying the file is worse than other available alternatives. For example you can use configure to discover the proper argument types, and then write a function that wraps ptrace and provides the needed casts. Tom