From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-103995-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4217 invoked by alias); 2 Aug 2013 17:00:42 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 4208 invoked by uid 89); 2 Aug 2013 17:00:42 -0000
X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1
Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 02 Aug 2013 17:00:41 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r72H0XXu002202	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 2 Aug 2013 13:00:33 -0400
Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r72H01It024421	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 2 Aug 2013 13:00:08 -0400
From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Keith Seitz <keiths@redhat.com>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] remove duplicates in search_symbols
References: <yjt2ppvmu3ae.fsf@ruffy.mtv.corp.google.com>	<CADPb22Q9PdFgG7M0zrge3cNyjiafTWaAECN99MOQDxqPB_2yOQ@mail.gmail.com>	<8738r68uze.fsf@fleche.redhat.com>	<20986.62497.975502.698564@ruffy.mtv.corp.google.com>	<51FB2A02.6080703@redhat.com> <87pptwdx41.fsf@fleche.redhat.com>	<CADPb22Q0_MWssituUuwV_HqptkUQLAU06SDfMGGPqa6XFG5PrA@mail.gmail.com>
Date: Fri, 02 Aug 2013 17:00:00 -0000
In-Reply-To: <CADPb22Q0_MWssituUuwV_HqptkUQLAU06SDfMGGPqa6XFG5PrA@mail.gmail.com>	(Doug Evans's message of "Fri, 2 Aug 2013 09:53:29 -0700")
Message-ID: <87r4ecc9ke.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-08/txt/msg00089.txt.bz2

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> /* Symbol searching */
Doug> /* Note: struct symbol_search, search_symbols, et.al. are declared
Doug> here,
Doug>    instead of making them local to symtab.c, for gdbtk's sake.  */

Funny.

Doug> [I could make it more prevalent though.  Say a comment at the
Doug> definition site of each function or some such?]

I hope the above is good enough.
I didn't notice it once, but OTOH that implies that I'd probably miss
other comments as well.

Tom