From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20851 invoked by alias); 9 Sep 2013 18:47:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20838 invoked by uid 89); 9 Sep 2013 18:47:21 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Sep 2013 18:47:21 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r89IlHV0008843 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 9 Sep 2013 14:47:18 -0400 Received: from barimba (ovpn-113-132.phx2.redhat.com [10.3.113.132]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r89IlG6M009591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 9 Sep 2013 14:47:17 -0400 From: Tom Tromey To: Phil Muldoon Cc: gdb-patches@sourceware.org Subject: Re: [python][patch] Add temporary breakpoint features to Python breakpoints. References: <522D9D57.5030309@redhat.com> Date: Mon, 09 Sep 2013 18:47:00 -0000 In-Reply-To: <522D9D57.5030309@redhat.com> (Phil Muldoon's message of "Mon, 09 Sep 2013 11:05:11 +0100") Message-ID: <87r4cxj0i3.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-09/txt/msg00308.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> This patch allows Python breakpoints to be made temporary on Phil> creation. It adds an optional argument, and keyword: "temporary". Phil> OK? Thanks, Phil. Phil> 2013-09-09 Phil Muldoon Phil> * python/py-breakpoint.c (bppy_get_temporary): New function. Phil> (bppy_init): New keyword: temporary. Parse it and set breakpoint Phil> to temporary if True. Is there a PR associated with this? I thought there was, but I didn't check. Phil> +@defvar Breakpoint.temporary Phil> +This attribute indicates whether the breakpoint was created as a Phil> +temporary breakpoint. Temporary breakpoints are automatically deleted Phil> +after that breakpoint has been hit. Access to this attribute, and all Phil> +other attributes and functions other than the @code{is_valid} Phil> +function, will result in an error after the breakpoint has been hit Phil> +(as it has been automatically deleted). This attribute is not Phil> +writable. I think it is worth spelling out what "hit" means. In particular I was wondering how it interacts with the "stop" method. Phil> + if (self_bp->bp->disposition == disp_del || Phil> + self_bp->bp->disposition == disp_del_at_next_stop) "||" at the wrong spot. Phil> + static char *keywords[] = { "spec", "type", "wp_class", "internal", "temporary", NULL }; This line is too long. Phil> + if (temporary) temporary != NULL Tom