From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19956 invoked by alias); 10 Oct 2013 20:52:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19943 invoked by uid 89); 10 Oct 2013 20:52:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2013 20:52:40 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9AKqaBX011485 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 10 Oct 2013 16:52:37 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9AKqZNb005530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 10 Oct 2013 16:52:36 -0400 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [commit/Ada] psymbol search failure due to comparison function discrepancy References: <1381231039-4090-1-git-send-email-brobecker@adacore.com> Date: Thu, 10 Oct 2013 20:52:00 -0000 In-Reply-To: <1381231039-4090-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Tue, 8 Oct 2013 15:17:19 +0400") Message-ID: <87r4bs4zn0.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00371.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> This patch aims at restoring the compatibility between the two Joel> functions, by adding case-sensitivity handling in the Ada comparison Joel> function. Joel> Tested on x86_64-linux. No testcase unfortunately, as the problem Joel> is sensitive to symbol names and ordering, and the only reproducer Joel> we have has non-contributable code in it. Is it possible to construct a synthetic test case using the DWARF assembler? I ask because I think that, while the patch is fine, having two functions which must remain in sync semantically, where one such function is only used by Ada and has no test case for some branches, is definitely going to cause future regressions. Tom