From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 407 invoked by alias); 7 Nov 2013 14:36:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 398 invoked by uid 89); 7 Nov 2013 14:36:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.2 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPAM_SUBJECT,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Nov 2013 14:36:50 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA7EadfJ014335 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Nov 2013 09:36:40 -0500 Received: from barimba (ovpn-113-94.phx2.redhat.com [10.3.113.94]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rA7Eabvv018317 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 7 Nov 2013 09:36:38 -0500 From: Tom Tromey To: Doug Evans Cc: Stan Shebs , gdb-patches@sourceware.org Subject: Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c References: <527AB482.80600@earthlink.net> <87ppqd1a0t.fsf@fleche.redhat.com> Date: Thu, 07 Nov 2013 14:53:00 -0000 In-Reply-To: (Doug Evans's message of "Wed, 06 Nov 2013 23:10:24 -0800") Message-ID: <87r4asz3be.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-11/txt/msg00173.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> Tom Tromey writes: Stan> +/* A helper function for tyscm_richcompare that checks two types for Stan> + "deep" equality. Returns non-zero if the types are considered the Stan> + same, zero otherwise. */ >> Stan> "tyscm_richcompare"? Should that be typy_... ? >> >> It would be helpful if Doug could list all the change he made when >> moving the code. Doug> I don't understand. Doug> Which changes? While useful beyond its present state, this is in Doug> essence just a cleanup. I had thought this patch was more or less a straight move of the code. But Stan's note revealed a change from what is currently in the tree. So the question is, can you say what else changed? That would be handy so I don't have to go over it line-by-line myself. Tom