From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17137 invoked by alias); 16 Jan 2014 17:57:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17101 invoked by uid 89); 16 Jan 2014 17:57:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2014 17:57:27 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0GHvPR4025435 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 16 Jan 2014 12:57:25 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s0GHvNvY022321 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 16 Jan 2014 12:57:24 -0500 From: Tom Tromey To: Markus Metzger Cc: jan.kratochvil@redhat.com, palves@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH v10 25/28] btrace, gdbserver: read branch trace incrementally References: <1389686678-9039-1-git-send-email-markus.t.metzger@intel.com> <1389686678-9039-26-git-send-email-markus.t.metzger@intel.com> Date: Thu, 16 Jan 2014 17:57:00 -0000 In-Reply-To: <1389686678-9039-26-git-send-email-markus.t.metzger@intel.com> (Markus Metzger's message of "Tue, 14 Jan 2014 09:04:35 +0100") Message-ID: <87r487n724.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00633.txt.bz2 >>>>> "Markus" == Markus Metzger writes: Hi Markus. Markus> -VEC (btrace_block_s) * Markus> -target_read_btrace (struct btrace_target_info *btinfo, Markus> +enum btrace_error Markus> +target_read_btrace (VEC (btrace_block_s) **btrace, Markus> + struct btrace_target_info *btinfo, Markus> enum btrace_read_type type) Markus> { Markus> struct target_ops *t; Markus> for (t = current_target.beneath; t != NULL; t = t->beneath) Markus> if (t->to_read_btrace != NULL) Markus> - return t->to_read_btrace (btinfo, type); Markus> + return t->to_read_btrace (btrace, btinfo, type); Markus> tcomplain (); Markus> - return NULL; Markus> + return BTRACE_ERR_NOT_SUPPORTED; Markus> } While rebasing my branch I noticed this code. tcomplain doesn't return, so the final "return" here will never be executed. Given the function's history I assume this is no big deal -- just a small oversight, compounded by the compiler not bothering to tell us that it knows about this :) However I wanted to point it out in case you were expecting an error return here. If it is not important, then please just ignore it. I have fixed it on my branch already. Tom