From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10415 invoked by alias); 19 May 2014 18:22:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10401 invoked by uid 89); 19 May 2014 18:22:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 May 2014 18:22:25 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4JIMMbG008485 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 May 2014 14:22:22 -0400 Received: from barimba (ovpn-113-182.phx2.redhat.com [10.3.113.182]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4JIMLNv031248 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Mon, 19 May 2014 14:22:21 -0400 From: Tom Tromey To: Jan Kratochvil Cc: Sergio Durigan Junior , gdb-patches@sourceware.org, Aleksandar Ristovski Subject: Re: [PATCH v5 1/8] Move utility functions to common/ References: <20140319223004.14668.20989.stgit@host1.jankratochvil.net> <20140319223014.14668.89536.stgit@host1.jankratochvil.net> <20140518190534.GA19591@host2.jankratochvil.net> Date: Mon, 19 May 2014 18:22:00 -0000 In-Reply-To: <20140518190534.GA19591@host2.jankratochvil.net> (Jan Kratochvil's message of "Sun, 18 May 2014 21:05:34 +0200") Message-ID: <87r43py6g3.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-05/txt/msg00365.txt.bz2 Sergio> Can't this go in independently? I think they are nice cleanups. Jan> I do not think it is right without the later parts of the patchset Jan> - code in gdb/common/ should be used by both gdb and gdbserver. Jan> Otherwise the code could remain in gdb/ only. If we had smaller files in common/ then we could put generically useful things there and not care so much, relying on the linker to eliminate bloat. Tom