From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21072 invoked by alias); 3 Jun 2014 08:33:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21023 invoked by uid 89); 3 Jun 2014 08:33:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: hera.aquilenet.fr Received: from hera.aquilenet.fr (HELO hera.aquilenet.fr) (141.255.128.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Jun 2014 08:33:09 +0000 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id AFA1A289A; Tue, 3 Jun 2014 10:33:07 +0200 (CEST) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JwNxj5VbEbav; Tue, 3 Jun 2014 10:33:07 +0200 (CEST) Received: from pluto (pluto.bordeaux.inria.fr [193.50.110.57]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 732FD6E5; Tue, 3 Jun 2014 10:33:07 +0200 (CEST) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Doug Evans Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH, doc RFA] Add guile gdb command support References: <83k39dn7ne.fsf@gnu.org> <83wqcz9vil.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 15 Prairial an 222 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu Date: Tue, 03 Jun 2014 08:33:00 -0000 In-Reply-To: (Doug Evans's message of "Tue, 03 Jun 2014 00:32:55 -0700") Message-ID: <87r436v1dp.fsf@gnu.org> User-Agent: Gnus/5.130009 (Ma Gnus v0.9) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-06/txt/msg00071.txt.bz2 Hi, Doug Evans skribis: > commit e698b8c41cbb2648a11a2ae806922c44d1482aed > Author: Doug Evans > Date: Tue Jun 3 00:29:49 2014 -0700 > > Add command support for Guile. >=20=20=20=20=20 > * Makefile.in (SUBDIR_GUILE_OBS): Add scm-cmd.o. > (SUBDIR_GUILE_SRCS): Add scm-cmd.c. > (scm-cmd.o): New rule. > * guile/guile-internal.h (gdbscm_gc_xstrdup): Declare. > (gdbscm_user_error_p): Declare. > (gdbscm_parse_command_name): Declare. > (gdbscm_valid_command_class_p): Declare. > (gdbscm_initialize_commands): Declare. > * guile/guile.c (initialize_gdb_module): Call > gdbscm_initialize_commands. > * guile/lib/gdb.scm: Export command symbols. > * guile/lib/gdb/init.scm (%exception-keys): Add gdb:user-error. > (throw-user-error): New function. > * guile/scm-cmd.c: New file. > * guile/scm-exception.c (user_error_symbol): New static global. > (gdbscm_user_error_p): New function. > (gdbscm_initialize_exceptions): Set user_error_symbol. > * scm-utils.c (gdbscm_gc_xstrdup): New function. >=20=20=20=20=20 > testsuite/ > * gdb.guile/scm-cmd.c: New file. > * gdb.guile/scm-cmd.exp: New file. >=20=20=20=20=20 > doc/ > * guile.texi (Guile API): Add entry for Commands In Guile. > (Basic Guile) : Add reference. > (Basic Guile) argv>: Move definition to Commands In Guile. > (GDB Scheme Data Types): Mention object. > (Commands In Guile): New node. Looks great to me (sorry for not commenting earlier.) Thanks, Ludo=E2=80=99.