From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Adrian Sendroiu <adrian.sendroiu@freescale.com>,
tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 2/2] mi-out: Implement mi redirection using a stack.
Date: Mon, 08 Sep 2014 18:59:00 -0000 [thread overview]
Message-ID: <87r3zmsztx.fsf@redhat.com> (raw)
In-Reply-To: <540DACE2.9060400@redhat.com> (Pedro Alves's message of "Mon, 08 Sep 2014 14:19:30 +0100")
On Monday, September 08 2014, Pedro Alves wrote:
>> + mi_expect_stop "breakpoint-hit" "do_nothing" ".*" ".*" ".*" {".*" ".*"} "Continue to breakpoint"
>> +
>> + # This will crash gdb if redirection is not done properly.
>> + mi_gdb_test "help" ".*" "nested redirect"
>
> I think it'd be good to replace this ".*" with a stricter match, just
> in case something goes wrong with undoing the redirection, but nothing
> crashes. Something like (untested):
>
> mi_gdb_test "help" "List of classes of commands.*\\^done.*" "nested redirect"
I've been seeing some cases like this in the list (i.e., writing tests
using ".*" a lot). Maybe this is a good thing to mention in our wiki...
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2014-09-08 18:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 14:26 [PATCH 0/2] Reimplement redirection for MI Adrian Sendroiu
2014-07-23 14:26 ` [PATCH 2/2] mi-out: Implement mi redirection using a stack Adrian Sendroiu
2014-07-24 20:34 ` Tom Tromey
2014-07-25 11:43 ` [PATCH v2 " Adrian Sendroiu
2014-07-29 15:16 ` Pedro Alves
2014-07-30 8:38 ` Adrian Sendroiu
2014-07-30 12:05 ` Pedro Alves
2014-07-31 16:23 ` Adrian Sendroiu
2014-07-31 17:11 ` Pedro Alves
2014-08-05 13:54 ` Adrian Sendroiu
2014-08-28 11:33 ` Adrian Sendroiu
2014-09-05 16:06 ` Pedro Alves
2014-09-07 15:45 ` Adrian Sendroiu
2014-09-08 13:19 ` Pedro Alves
2014-09-08 18:59 ` Sergio Durigan Junior [this message]
2014-09-09 14:03 ` Adrian Sendroiu
2014-09-26 9:25 ` Adrian Sendroiu
2014-09-26 12:51 ` Pedro Alves
2014-07-23 14:37 ` [PATCH 1/2] cli/cli-logging.c: don't call ui_out_redirect for MI when disabling logging Adrian Sendroiu
2014-07-24 18:19 ` Tom Tromey
2015-08-17 18:47 ` [PATCH 0/2] Reimplement redirection for MI Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3zmsztx.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=adrian.sendroiu@freescale.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox