From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31813 invoked by alias); 20 Nov 2014 02:11:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31760 invoked by uid 89); 20 Nov 2014 02:11:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: layla.krisman.be Received: from layla.krisman.be (HELO layla.krisman.be) (176.31.208.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 20 Nov 2014 02:11:25 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (envelope-from ) id 1XrH73-00075m-Pj; Thu, 20 Nov 2014 03:05:11 +0100 From: Gabriel Krisman Bertazi To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] Create syscall groups for x86_64. References: <1414956944-8856-1-git-send-email-gabriel@krisman.be> <1414956944-8856-4-git-send-email-gabriel@krisman.be> <87ppcp75hd.fsf@redhat.com> Date: Thu, 20 Nov 2014 02:11:00 -0000 In-Reply-To: <87ppcp75hd.fsf@redhat.com> (Sergio Durigan Junior's message of "Fri, 14 Nov 2014 18:00:14 -0500") Message-ID: <87r3wyoc5q.fsf@krisman.be> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00448.txt.bz2 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 1500 Sergio Durigan Junior writes: Sergio, Thank you for your review. I applied your suggestions and I will send the updated patches to this list in a few moments. > On Sunday, November 02 2014, Gabriel Krisman Bertazi wrote: > >> This commit introduces the following syscall groups for the x86_64 >> architecture: memory, ipc, process, descriptor, signal and file. >> >> Please note that the sorting of the syscalls among these several groups >> follows the same structure used in strace. >> >> This also introduces tests for catching groups of syscalls on the x86_64 >> architecture. > > I guess I said that before, but just in case I didn't: I would prefer if > this patch already updated the other architectures as well. IIUC you > are planning to do that in another series of patches, but it would be > good if you did everything at once, I think. However, I will not oppose > if you decide to touch only on x86_64 for now. Updating the syscall files by hand is quite error-prone and requires lots of typing. Should we bring PR 14276 to the table, it would also require extra work to update the groups later. A few weeks ago, you and I talked about writing a script to fix PR14276. What I want to do is to save me some typing now and update the other architectures only after we have such script to generate the syscall files, so we can use it to also generate the group information automatically. What do you think? Is that ok for you? --=20 Gabriel Krisman Bertazi --=-=-= Content-Type: application/pgp-signature Content-length: 818 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUbU1xAAoJEO9pqxSS5VgPvcsP/R5XnKi4nTiOfM+5feyc/CXE PE9kZE+NZKrfi3MsKcB4/xAD2XQMyHcZnIoDUqWCkrBqlIFIQZB73dNWDqd9OOo9 SpZjMwDjP+K8G9wQ9ZlKN5A+ut0CflAcvYE9gid6Wo1oqTQO2y08To5W0GLLJ/pf 7eO4w+TbNf6IYMbYLoDuxChJJZFmUIzoT7QZ2dFvniWIYYJJPnm8F+/xZGDAhyB+ gv2cBta5oHxLLEKVE3QIreMra9GO7Hf/8GAs4m+sAUUqvY3F0HwtFrWVF6fP1f/G fkOCa5M1MscVuBK0G8HkrotZPW30BnAuVb2FO3YWsSP1mW9B8IaN1ZtL0oC6K9aQ ravQ1O7+9Y2GQqCxYN+mAjgIE7fUo3NQTMczg+RxMEkQxM2qEF8783Exr8NHr0go 8KmybtC0BYBUx1TSYIrLIbUWm98gH/SzEv4F/R+YdKB49ZIBmc3kHRfF833n7PXa OOjmopyxrOUsbJsYrmZ5oc5kAu5pSj8lyDsG2OQbyzz4gx+T2GLwDCdNxuMpT1NV rKOH7xxHkMZFHUC6lBv926idQOu2x7tWJgklU0VQEhFrCjOhWbTF3ucYNFr+rUil YUjWRHcB6NzYsO6CU5HrsXRpVFBh0AMHdE3ssXXu9GcG3HR3bhPcfAsoas1ivssn 6XxdBK0ETdDKL5U00OXP =aVGH -----END PGP SIGNATURE----- --=-=-=--