From: Yao Qi <yao@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: <gdb-patches@sourceware.org>, Sasha Smundak <asmundak@google.com>
Subject: Re: [testsuite patch] Fix new FAIL: py-frame.exp: test Frame.read_register(rip)
Date: Sun, 11 Jan 2015 13:58:00 -0000 [thread overview]
Message-ID: <87r3v1s9ld.fsf@codesourcery.com> (raw)
In-Reply-To: <20150107143820.GA1482@host2.jankratochvil.net> (Jan Kratochvil's message of "Wed, 7 Jan 2015 15:38:20 +0100")
Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> # On x86-64, PC is in $rip register.
> -if {[istarget x86_64-*]} {
> +if {[is_amd64_regs_target]} {
> gdb_test "python print ('result = %s' % (f0.read_register('pc') == f0.read_register('rip')))" \
> " = True" \
> "test Frame.read_register(rip)"
Hi, Jan,
With your patch applied, this test is skipped on 'x86_64 -m32'. I
prefer to increasing the test coverage, so how about extending the test
for 'x86_64 -m32'? I mean test Frame.read_register(eip)...
--
Yao (齐尧)
next prev parent reply other threads:[~2015-01-11 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 14:38 Jan Kratochvil
2015-01-11 13:58 ` Yao Qi [this message]
2015-01-11 14:51 ` Jan Kratochvil
2015-01-12 1:38 ` Yao Qi
2015-01-12 10:05 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3v1s9ld.fsf@codesourcery.com \
--to=yao@codesourcery.com \
--cc=asmundak@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox