From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35223 invoked by alias); 10 May 2015 18:34:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35211 invoked by uid 89); 10 May 2015 18:34:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY,URIBL_DBL_SPAM autolearn=no version=3.3.2 X-HELO: layla.krisman.be Received: from layla.krisman.be (HELO layla.krisman.be) (176.31.208.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 10 May 2015 18:34:44 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (envelope-from ) id 1YrVrH-0007sN-Fx; Sun, 10 May 2015 20:21:48 +0200 From: Gabriel Krisman Bertazi To: Pedro Alves Cc: Sergio Durigan Junior , gdb-patches@sourceware.org, dje@google.com Subject: Re: [PATCH v3 00/17] Catch syscall group References: <1430011521-24340-1-git-send-email-gabriel@krisman.be> <553F6BC0.9000905@redhat.com> <87r3r42e0v.fsf@redhat.com> <5540ABF8.4000404@redhat.com> <87k2wpt6k6.fsf@krisman.be> <554A275C.80204@redhat.com> Date: Sun, 10 May 2015 18:34:00 -0000 In-Reply-To: <554A275C.80204@redhat.com> (Pedro Alves's message of "Wed, 06 May 2015 15:38:20 +0100") Message-ID: <87r3qoi8n6.fsf@krisman.be> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00230.txt.bz2 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 1635 Pedro Alves writes: >> in a xml file and teach GDB about it or generate the full xml file >> during the build; (2) keep the group information inside a tabular text >> file and use a simple text substitution to generate the full xml during >> the build. >>=20 >> Personally, even though I'm not a big fan of the XML format in general, >> I dislike option (2) because inserting a tabular text file now feels a >> little clumsy. since we already use XML for syscalls, I think syscall >> groups should be stored similarly. >>=20 >> I plan to send a new version later this week (as soon as I have a break >> From college) that implements Pedro's first suggestion. Now, we keep >> the information inside linux-defaults.xml and have a XSL script to >> performs a join of the information and generate the full XML file. > > Sounds great. Thanks! I have a question before sending the new version. I noticed that the GDB build step currently doesn't depend on xsltproc. It is used only in gdb/features/Makefile to generate some .dat files, that are also included in the repository at gdb/regformat. Am I right? At first, I intended to use xsltproc as a build step and only provide the *.xml.in files in the repository. But that would have the side effect of forcing xsltproc to be available at build time, and I don't know if is acceptable. Other possibility would be to also push the generated files to the repository. We'd keep them in gdb/syscalls/generated/, or something like that, and have a script to update the xmls when needed. What do you think is the best approach here? --=20 Gabriel Krisman Bertazi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 818 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVT6S9AAoJEO9pqxSS5VgPcQ4P/1/yDFeLMlBpySHbG1HCNalA CvPq2dG55eVO02U/PKSoSB2658dH67a3huib34FIFVhb4eoAu/Immju1jq6d2sb5 L+Vz6RWEJt3UhS07DZ9uy6daqcQGTTU7DdEkBJUSsd110l+UMxv07l2EvwZhmXMD TLVN+TsvNTpSU1LP6ZJkbSMS8pogYHRZ2Zd+B4fK5fknUACgAYi8VdHDk9si1tP8 eMLQXGXk6IMnMKX2k3AbYqVYNBLccBrvVFIbMmjZfMRX8Am2n26win458aWRXoLo LD+0Ko4Z2Zzl+OcCauIT/m5tM48Yh7zuFJPA5tO6U1xxN+bgQvPZTsmm1SEnftaS Q8GVilWi3OLuRtEDXAIYnr/zYnSdk6RmUOaKq2V7HbXyQ/Ovm6rRABFRGwvjg2H/ qj3CN7aDHHWtjhLkdqEwqNxAihc6UHysnffL8DfCFy1XJxDrtE3oSOiBwRN0u3aW jvAawUMp1YVGdk++G7n5oi/ZGCVgzAPbh65tUMCQhkFXwS4lJLJ0xhz04X9LP6Wh 25JSTd0Qrlsss/cwfNs3sj/QeSxM3ICf3IYSiMXZ+z3QmlU+vdBHt3trIUib0K1Z WiC5Fj12pLkCM40UyBZCHlowZ4LgO8Ffb8aKxccfBn9NycvFrIOkYhub6goyS5VP EVgHXknepG2fbnwyL2U/ =g//Q -----END PGP SIGNATURE----- --=-=-=--