From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85274 invoked by alias); 20 Jul 2015 15:35:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85259 invoked by uid 89); 20 Jul 2015 15:35:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 20 Jul 2015 15:35:21 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 91CA991DA3; Mon, 20 Jul 2015 15:35:19 +0000 (UTC) Received: from localhost (unused-10-15-17-51.yyz.redhat.com [10.15.17.51]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6KFZIKQ003153 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 20 Jul 2015 11:35:19 -0400 From: Sergio Durigan Junior To: Pierre-Marie de Rodat Cc: Joel Brobecker , Pedro Alves , GDB Patches Subject: Re: [PATCH] Share the "multi_line" helper among all Ada testcases References: <54FEDB92.9060808@adacore.com> <20150317200809.GD7494@adacore.com> <5509492C.5000604@redhat.com> <20150318141238.GE7494@adacore.com> <550C100D.5000500@adacore.com> <87oajas3pb.fsf@redhat.com> <55AD0A6E.6060604@adacore.com> X-URL: http://blog.sergiodj.net Date: Mon, 20 Jul 2015 15:35:00 -0000 In-Reply-To: <55AD0A6E.6060604@adacore.com> (Pierre-Marie de Rodat's message of "Mon, 20 Jul 2015 16:49:18 +0200") Message-ID: <87r3o2rgeh.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00566.txt.bz2 Hey Pierre, On Monday, July 20 2015, Pierre-Marie de Rodat wrote: > On 07/18/2015 02:35 AM, Sergio Durigan Junior wrote: >> Hmm, I am seeing a regression on gdb.ada/info_exc.exp because of this >> patch. Because of the way multi_line was rewritten it is not possibe >> anymore to mean "anything" again; it will always be at least a newline >> (\r\n). >> >> I've rewritten the test to expect the exact output from "info >> exceptions" (i.e., removing the ".*" parts), but I am not sure this is >> the right thing to do. Joel/Pierre? > > Thank you for the heads-up! I did not notice this when submitting the > patch... Anyway, I had a look at what commit introduced the ".*" > parts: > > commit 391d3400084c6a2d805cd0efd925f29347fa7a18 > Author: Joel Brobecker > Date: Fri Nov 15 20:34:09 2013 +0400 > > gdb.ada/info_exc.exp,mi_exc_info.exp: handle runtimes with full > debug info. > > If the runtime has full debug info, then the non-standard exceptions > declared in the GNAT runtime will appear in the list of exceptions > printed by GDB ("info exceptions" or "-info-ada-exceptions"). > This is valid output, so this patch allows for it. > > So it looks like they are needed for some configuration. Then, what > about this: Hm, right, thanks for checking this. I suspected that the ".*" had a reason to exist... > diff --git a/gdb/testsuite/gdb.ada/info_exc.exp > b/gdb/testsuite/gdb.ada/info_exc.exp > index add83c5..448882b 100644 > --- a/gdb/testsuite/gdb.ada/info_exc.exp > +++ b/gdb/testsuite/gdb.ada/info_exc.exp > @@ -34,9 +34,7 @@ gdb_test "info exceptions" \ > "program_error: $hex" \ > "storage_error: $hex" \ > "tasking_error: $hex" \ > - ".*" \ > - "const.aint_global_gdb_e: $hex" \ > - ".*"] > + "\(.*\r\n\)*const.aint_global_gdb_e: $hex\(.*\r\n\)*"] > > gdb_test "info exceptions task" \ > [multi_line "All Ada exceptions matching regular expression > \"task\":" \ The patch looks good to me and works fine here (though I haven't tested the case when the output contains more lines than expected). I'm not a maintainer of this area, so I cannot really approve this. Thanks! -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/