From: Andreas Schwab <schwab@linux-m68k.org>
To: Nick Clifton <nickc@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Commit: AArch64 sim: Fix off by one error checking for invalid vector array element
Date: Fri, 18 Mar 2016 14:54:00 -0000 [thread overview]
Message-ID: <87r3f7n8f4.fsf@linux-m68k.org> (raw)
In-Reply-To: <87fuvnu9q7.fsf@redhat.com> (Nick Clifton's message of "Fri, 18 Mar 2016 14:44:16 +0000")
Nick Clifton <nickc@redhat.com> writes:
> diff --git a/sim/aarch64/cpustate.c b/sim/aarch64/cpustate.c
> index 86b1b15..19f485e 100644
> --- a/sim/aarch64/cpustate.c
> +++ b/sim/aarch64/cpustate.c
> @@ -345,7 +345,7 @@ aarch64_set_FP_long_double (sim_cpu *cpu, VReg reg, FRegister a)
> #define GET_VEC_ELEMENT(REG, ELEMENT, FIELD) \
> do \
> { \
> - if (element > ARRAY_SIZE (cpu->fr[0].FIELD)) \
> + if (element >= ARRAY_SIZE (cpu->fr[0].FIELD)) \
s/element/ELEMENT/
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2016-03-18 14:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 14:44 Nick Clifton
2016-03-18 14:54 ` Andreas Schwab [this message]
2016-03-18 17:10 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3f7n8f4.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=gdb-patches@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox