From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34968 invoked by alias); 11 Oct 2016 17:31:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34955 invoked by uid 89); 11 Oct 2016 17:31:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Tue, 11 Oct 2016 17:31:17 +0000 Received: (qmail 16335 invoked by uid 0); 11 Oct 2016 17:31:15 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy6.mail.unifiedlayer.com with SMTP; 11 Oct 2016 17:31:15 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id uHXA1t00r2f2jeq01HXDa6; Tue, 11 Oct 2016 11:31:13 -0600 X-Authority-Analysis: v=2.1 cv=beT4Do/B c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=20KFwNOVAAAA:8 a=NZE-ujecsiR8dkkA2FUA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 71-218-192-86.hlrn.qwest.net ([71.218.192.86]:51350 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bu0tT-0004l1-Uv; Tue, 11 Oct 2016 11:31:12 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 11/22] Change command stats reporting to use class References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-12-git-send-email-tom@tromey.com> Date: Tue, 11 Oct 2016 17:31:00 -0000 In-Reply-To: (Pedro Alves's message of "Sun, 9 Oct 2016 18:01:48 +0100") Message-ID: <87r37mokrm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bu0tT-0004l1-Uv X-Source-Sender: 71-218-192-86.hlrn.qwest.net (bapiya) [71.218.192.86]:51350 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00270.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Did you try splitting the reindented code to a separate Pedro> function instead? Thanks. I did this and in the process noticed that the earlier patch was incorrect -- it left a dangling cleanup. I have a follow-on patch now to remove that last cleanup from captured_main. Tom