Re: Oh dear. I regret to inform you that commit b1308d2c3749cc454f00b70768ee33724d919527 might be unfortunate

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Thursday, September 07 2017, I wrote:

> On Thursday, September 07 2017, Palmer Dabbelt wrote:
>
>> I think this wasn't my commits, as it seems to be broken as of 63c99141deff
>> ("remove QStartupWithShell entry from NEWS::Changes in GDB 7.11").  Also, I
>> haven't touched anything in aarch64 GDB land
>>
>>   https://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-native-gdbserver-m64/builds/2745
>>
>> I can't find any other mention of this on "gdb-patches", though I'm not a GDB
>> maintainer (we don't have a RISC-V GDB port yet) so I had to poke around the
>> archives and therefor may be missing something.  According to here
>>
>>   https://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-native-gdbserver-m64?numbuilds=400
>>
>> This has been broken since 34d16ea2a144 ("gdb.base/commands.exp: Test
>> loop_break and loop_continue in nested loops"), but that failure isn't relevant
>> to this one as it's a test failure not a build failure.
>>
>>   https://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-native-gdbserver-m64/builds/2671
>>
>> I poked around and there was at least one compilation failure in
>> between the one I just got emailed about and the test failure above, caused by
>> 7022349d5c86 ("Stop assuming no-debug-info functions return int").
>>
>>   https://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-native-gdbserver-m64/builds/2673/steps/compile%20gdb/logs/stdio
>>
>> Given that there's two different failures in three commits and I'm pretty sure
>> I didn't cause this bug, I don't want to dig through the rest of the history to
>> figure out what's going on.  This has been broken for a while, is everyone else
>> just ignoring these messages?
>
> Hi Palmer,
>
> Thanks for investigating these issues.
>
> There's been a bunch of compilation errors on this builder,
> unfortunately.  The last one is caused by commit
> f7000548a2b79d7e5cb924468117ca4245e6b820, from Yao.
>
> Yao, could you please take a look at the error?  You can see the build
> logs here:
>
>   https://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-native-gdbserver-m64/builds/2696/steps/compile%20gdb/logs/stdio

FWIW, I sent a patch that fixes this:

  <https://sourceware.org/ml/gdb-patches/2017-09/msg00264.html>

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/