From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14545 invoked by alias); 14 Sep 2017 15:33:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14518 invoked by uid 89); 14 Sep 2017 15:33:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Sep 2017 15:33:02 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B684D66C59 for ; Thu, 14 Sep 2017 15:33:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B684D66C59 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8CC566FE47; Thu, 14 Sep 2017 15:33:01 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH 3/4] Introduce gdb_chdir References: <20170912042325.14927-1-sergiodj@redhat.com> <20170912042325.14927-4-sergiodj@redhat.com> <6f978544-e1d4-b921-2e10-6be7f0e6b563@redhat.com> <87vakluxb1.fsf@redhat.com> <564dbed5-841d-be08-7827-19c898a3d0b1@redhat.com> Date: Thu, 14 Sep 2017 15:33:00 -0000 In-Reply-To: <564dbed5-841d-be08-7827-19c898a3d0b1@redhat.com> (Pedro Alves's message of "Thu, 14 Sep 2017 16:23:16 +0100") Message-ID: <87r2v9uwgj.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00386.txt.bz2 On Thursday, September 14 2017, Pedro Alves wrote: > On 09/14/2017 04:14 PM, Sergio Durigan Junior wrote: >> On Wednesday, September 13 2017, Pedro Alves wrote: >> >>> On 09/12/2017 05:23 AM, Sergio Durigan Junior wrote: > >>>> +/* Perform path expansion (i.e., tilde expansion) on DIR, and return >>>> + the full path. */ >>>> + >>>> +static std::string >>>> +expand_path (const char *dir) >>> >>> Since this is particularly about tilde expansion, >>> and a replacement for "tilde_expand", did you consider calling >>> it gdb_tilde_expand and using it throughout? If this were an >>> extern function, I'd press for having "tilde" in its name, >>> to make the call sites a bit more obvious. >> >> Sure, no problem in renaming it. Just to clarify: when you mean "use it >> throughout", are saying that this should be used to replace readline's >> "tilde_expand" elsewhere on GDB? > > Yes, and no. Yes, by 'throughout' I meant elsewhere in GDB. > But no, I'm not _saying_ it should. I'm really asking if you > considered/thought about that. I thought about that while I was making the patch. My very initial plan was to actually use 'wordexp', but I gave up on that when I noticed that the function is not implemented in many targets and gnulib doesn't provide a module for it. So I went ahead and decided to use glob, but left the "cd_command" untouched just because it is "already working" (TM). > I think what I'm really wondering is whether tilde_expand > and this new function behave exactly the same, or whether > glob behaves a little different in some cases. If it behaves > differently [and the differences are benign), then I get to > wonder whether we should use it throughout so that different > commands don't behave differently. > > E.g., does "cd *" behave the same before/after ? Or does > 'glob' expand '*' while tilde_expand didn't? >From my initial tests I can see that "glob" and "tilde_expand" behave the same, but I'll try to test more corner cases and see the results. Apparently it'll be fine to just replace "tilde_expand". -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/