From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23580 invoked by alias); 22 Sep 2017 18:15:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21074 invoked by uid 89); 22 Sep 2017 18:15:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Sep 2017 18:15:16 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F3A3181DE1; Fri, 22 Sep 2017 18:15:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com F3A3181DE1 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B6B0860466; Fri, 22 Sep 2017 18:15:11 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH v3 4/5] Implement "set cwd" command on GDB References: <20170912042325.14927-1-sergiodj@redhat.com> <20170921225926.23132-1-sergiodj@redhat.com> <20170921225926.23132-5-sergiodj@redhat.com> <83poajcg9a.fsf@gnu.org> Date: Fri, 22 Sep 2017 18:15:00 -0000 In-Reply-To: (Pedro Alves's message of "Fri, 22 Sep 2017 13:31:21 +0100") Message-ID: <87r2uy38i8.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00688.txt.bz2 On Friday, September 22 2017, Pedro Alves wrote: > On 09/22/2017 09:02 AM, Eli Zaretskii wrote: >>> From: Sergio Durigan Junior > >> >>> +@kindex set cwd >>> +@cindex change inferior's working directory >>> +@item set cwd @r{[}@var{directory}@r{]} >>> +Set the inferior's working directory to @var{directory}. If not >>> +given, @var{directory} uses @file{'~'}. >> >> I think we should document here what does "~" mean on MS-Windows, >> especially since, when HOME is not in the environment, Gnulib's glob >> module doesn't behave according to MS platform recommendations (which >> say not to create files directly below %HOMEDRIVE%%HOMEPATH%). >> >> More generally, I think we should say here that the argument is >> glob-expanded, because this is user-visible behavior (right?). Also, >> how will TAB-completion react to input of this command? will it expand >> the input typed so far? > > Actually, should the command default to ~ at all? Shouldn't we > make "set cwd" clear the setting to the default state, i.e., > empty? Otherwise, how do you get back to the default state? That's a good point. "set cwd" currently mimics what "cd" does, and that's the reason for this "default is to use ~" decision. I can certainly make "set cwd" without arguments to clear out whatever has been set by the user. I think that's a more sensible decision indeed. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/