From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29835 invoked by alias); 28 Nov 2017 16:08:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29826 invoked by uid 89); 28 Nov 2017 16:08:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.7 required=5.0 tests=BAYES_00,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Nov 2017 16:08:47 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 581DBFECF for ; Tue, 28 Nov 2017 16:08:46 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 31FFE60175; Tue, 28 Nov 2017 16:08:43 +0000 (UTC) From: Sergio Durigan Junior To: Sergio Lopez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] Enable the user to dump all memory regions References: <20171128132148.31802-1-slp@redhat.com> Date: Tue, 28 Nov 2017 16:08:00 -0000 In-Reply-To: <20171128132148.31802-1-slp@redhat.com> (Sergio Lopez's message of "Tue, 28 Nov 2017 14:21:44 +0100") Message-ID: <87r2simlmd.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00734.txt.bz2 On Tuesday, November 28 2017, Sergio Lopez wrote: > GDB versions prior to df8411da087dc05481926f4c4a82deabc5bc3859 > unconditionally included all memory regions in the core dump. > > After that change, while is still possible to ask GDB to ignore > /proc/PID/coredump_filter using the 'set use-coredump-filter' command, > there's no way to request it to dump regions marked with the VM_DONTDUMP > flag ("dd" in /proc/PID/smaps"). > > This patch series implement the new 'set honor-dontdump-flag' command > for GDB, and the "-a" argument for gcore, allowing the user to mimic the > behavior of previous GDB versions. Thanks for the patch, Sergio. Overall I agree with the approach, but I've made a few comments here and there about things I think should be addressed. The most important of them is the command name. I would really like to see a test for this. We already carry a testcase for the use-coredump-filter command (see gdb.base/coredump-filter.exp), so I think you can just extend it to test this specific feature. Thanks, > Sergio Lopez (4): > Implement 'set honor-dontdump-flag' command > Document new 'set honor-dontdump-flag' command > Add "-a" argument to gcore.in > Document the new "-a" argument for gcore > > gdb/ChangeLog | 10 ++++++++++ > gdb/doc/ChangeLog | 9 +++++++++ > gdb/doc/gdb.texinfo | 18 +++++++++++++++++- > gdb/gcore.in | 25 +++++++++++++++++++++++-- > gdb/linux-tdep.c | 19 ++++++++++++++++++- > 5 files changed, 77 insertions(+), 4 deletions(-) > > -- > 2.14.3 -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/