From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108924 invoked by alias); 14 Jul 2018 12:39:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108910 invoked by uid 89); 14 Jul 2018 12:39:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.62.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Jul 2018 12:39:08 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 0E1A3400CEA55 for ; Sat, 14 Jul 2018 07:39:07 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id eJpKfNudEBcCXeJpLf4Voa; Sat, 14 Jul 2018 07:39:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2PLuVNp1kvmcYLMsgH75+FKyVcFYPqgMrNKzIVZa/Z4=; b=NxlSs4NxXe5i+3aXazSFDEuopE xAGSFIxehF75uYTJLG7Fo99+C5VLqPQseilOuGPqiHRwnUhmynhbo9DqFhLSoacbF1kD0FlsUlGBU fLdCam6hGlIq+BkH+zwOt+8Fy; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:35132 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1feJpK-004EiJ-PL; Sat, 14 Jul 2018 07:39:06 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 07/13] Remove unused declaration from py-prettyprint.c References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-8-tom@tromey.com> Date: Sat, 14 Jul 2018 12:39:00 -0000 In-Reply-To: (Simon Marchi's message of "Fri, 13 Jul 2018 21:24:13 -0400") Message-ID: <87r2k69el2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00448.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Also LGTM. However, since both extension languages call value_contents_for_printing Simon> (from what I understand, to ensure the value has been fetched/is not lazy) and bail Simon> if some bytes are unavailable, perhaps apply_ext_lang_val_pretty_printer should Simon> do it instead. It seems possible that someday we'd want to expose unavailable bytes via the Python Value API. Simon> Also, doing Simon> if (value->lazy) Simon> value_fetch_lazy (value); Simon> would communicate better the intent than calling value_contents_for_printing for the Simon> same side-effect. True, but then this is exposed to other possible changes in the value API. Tom