From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/7] Avoid -Wnarrowing warnings in struct tramp_frame instances
Date: Thu, 09 Aug 2018 18:17:00 -0000 [thread overview]
Message-ID: <87r2j776cm.fsf@tromey.com> (raw)
In-Reply-To: <1dc16fd5-381b-fa3e-184f-1a54aac01529@redhat.com> (Pedro Alves's message of "Thu, 9 Aug 2018 19:08:39 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> On 08/09/2018 12:20 AM, Tom Tromey wrote:
>> --- a/gdb/common/common-types.h
>> +++ b/gdb/common/common-types.h
>> @@ -58,6 +58,9 @@ typedef unsigned long long ULONGEST;
>> /* * The largest CORE_ADDR value. */
>> #define CORE_ADDR_MAX (~ (CORE_ADDR) 0)
>>
>> +/* * The largest ULONGEST value. */
>> +#define ULONGEST_MAX (~ (ULONGEST) 0)
Pedro> With '~' being a unary operator, the right format would be:
Pedro> #define ULONGEST_MAX (~(ULONGEST) 0)
Pedro> But I see that CORE_ADDR_MAX has the same issue...
I'll just fix them both in the next revision.
Tom
prev parent reply other threads:[~2018-08-09 18:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 23:20 [PATCH 0/7] Remove -Wno-narrowing Tom Tromey
2018-08-08 23:20 ` [PATCH 5/7] Avoid -Wnarrowing warnings in ppc64-tdep.c Tom Tromey
2018-08-08 23:20 ` [PATCH 6/7] Avoid -Wnarrowing warnings in gdbserver Tom Tromey
2018-08-08 23:20 ` [PATCH 2/7] Use CORE_ADDR_MAX in various "breaks" arrays Tom Tromey
2018-08-09 18:08 ` Pedro Alves
2018-08-08 23:20 ` [PATCH 7/7] Remove -Wno-narrowing from warnings.m4 Tom Tromey
2018-08-09 18:10 ` Pedro Alves
2018-08-27 17:46 ` Tom Tromey
2018-08-27 18:00 ` Tom Tromey
2018-08-08 23:20 ` [PATCH 4/7] Fix two -Wnarrowing warnings in xtensa-tdep.h Tom Tromey
2018-08-09 18:09 ` Pedro Alves
2018-08-08 23:20 ` [PATCH 1/7] Change completion_tracker to use char type Tom Tromey
2018-08-09 17:38 ` Pedro Alves
2018-08-09 18:42 ` Tom Tromey
2018-08-09 18:50 ` Pedro Alves
2018-08-08 23:20 ` [PATCH 3/7] Avoid -Wnarrowing warnings in struct tramp_frame instances Tom Tromey
2018-08-09 18:08 ` Pedro Alves
2018-08-09 18:17 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2j776cm.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox