Re: [PATCH] Indicate batch mode failures by exiting with nonzero status

[Tom Tromey <tom@tromey.com>]

>>>>> "Gary" == Gary Benson <gbenson@redhat.com> writes:

Gary> +/* Did the last invocation of catch_command_errors throw an error?  */
Gary> +
Gary> +static bool last_command_failed = false;

catch_command_errors seems to return a boolean, so I think a global
shouldn't be necessary.

Also, why just the last command?  I mean, I guess I don't really know
what I would expect, but maybe if any command failed, gdb should exit?

Right now there seems to be a discrepancy where if you do
"gdb -ex fail -ex fail -ex fail", each one will be run; but if you
put the commands into a file and "gdb -x file", then only the first one
will be run.  I'm not sure if this is good or bad.

I suppose one nice thing about the "last command only" approach is that
you could ignore failures by tacking on one more -ex with some sort of no-op.

Tom