From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43696 invoked by alias); 28 Aug 2018 17:44:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43490 invoked by uid 89); 28 Aug 2018 17:44:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.23) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Aug 2018 17:44:34 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway33.websitewelcome.com (Postfix) with ESMTP id C0EC5ECA54 for ; Tue, 28 Aug 2018 12:44:32 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ui2AfZnQRbXuJui2QfvHAE; Tue, 28 Aug 2018 12:44:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RK8VG+zofPd4L3LE2WwLt+YBAy6+PqBV3vto7ZDfvbQ=; b=ip9VH3OVI34mkn98cSher+QPKo SjUNU8x4kNVG2Qs3LFtVyvFP2z3jLq5SvHYlaQc5ZmDK2O9s4UFq/v85rFCzuXPBYk8i91W3oasy7 +8HBkup7JOZ2IqMOrhQy3pLWm; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:47966 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fui2A-001xKc-K7; Tue, 28 Aug 2018 12:44:06 -0500 From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 4/9] Change `minimal_symbols' to std::vector in linespec.c structures References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-5-keiths@redhat.com> <87tvo1t0bb.fsf@tromey.com> <16508f0b-0525-e5b1-fe91-bd99931e0341@redhat.com> Date: Tue, 28 Aug 2018 17:44:00 -0000 In-Reply-To: <16508f0b-0525-e5b1-fe91-bd99931e0341@redhat.com> (Keith Seitz's message of "Fri, 17 Aug 2018 11:00:40 -0700") Message-ID: <87r2ii5qu2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00700.txt.bz2 >>>>> "Keith" == Keith Seitz writes: >> I think this should be changed to use std::sort. >> If I'm reading correctly, this is the only caller of compare_msymbols, >> so this transform shouldn't be too hard to do. Keith> Done. New patch below. [This is the only change in this revision.] Thanks, this is ok. Tom