From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90875 invoked by alias); 18 Sep 2018 11:59:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90859 invoked by uid 89); 18 Sep 2018 11:59:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=6.6 X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.60) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Sep 2018 11:59:46 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway23.websitewelcome.com (Postfix) with ESMTP id E54AC181E2 for ; Tue, 18 Sep 2018 06:59:44 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 2Ef4gKhJ3BcCX2EfHgjVGd; Tue, 18 Sep 2018 06:59:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qMujlL1csJePkR0F5ewOCv3trv+K+XBJvZCCQoYTsQc=; b=E5+ydxDZQINvMwgTygjlZz2VoB JazQWfq705k22JvGkvBVji7ZEfiH1EYvK5DEZ43I6LzqVJEYllQFnDc9wTghfbw/Eomt4qpGGVoOW WPJFMIOvQ9Cl5Pb+JLjJoV2uB; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:50324 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g2Ef4-001Ari-6c; Tue, 18 Sep 2018 06:59:22 -0500 From: Tom Tromey To: Weimin Pan Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 PR gdb/16841] virtual inheritance via typedef cannot find base References: <1536800471-78975-1-git-send-email-weimin.pan@oracle.com> Date: Tue, 18 Sep 2018 11:59:00 -0000 In-Reply-To: <1536800471-78975-1-git-send-email-weimin.pan@oracle.com> (Weimin Pan's message of "Wed, 12 Sep 2018 20:01:11 -0500") Message-ID: <87r2hrt3s6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00627.txt.bz2 >>>>> ">" == Weimin Pan writes: >> +2018-09-12 Weimin Pan >> + >> + PR gdb/16841 This should read "PR c++/16841". The robot doesn't care but I suppose it's a bit clearer for humans. >> + PR gdb/16841 Here too. >> + gdb_test "print ${scope}d" " = 6.5999999999999996" It's best with floats to use a number that is exact. So, instead of 6.6, 6.25 or something like that. The code has a loop to deal with multiple inheritance but the test doesn't exercise this case. I think an additional for that would be good. >> + if (get_baseclass_offset (domain, curtype, v, &boff, >> + &isvirt)) >> + mem_offset += boff; >> + else >> + { >> + struct type *t = check_typedef (value_type (this_v)); >> + t = check_typedef (TYPE_TARGET_TYPE (t)); >> + if (get_baseclass_offset (t, curtype, this_v, >> + &boff, &isvirt)) >> + mem_offset += boff; Could you explain this "else" block? I did not understand the reason for it. I suppose it could use a comment. thanks, Tom