From: Tom Tromey <tom@tromey.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFC] Avoid crash when calling warning too early
Date: Sat, 06 Oct 2018 21:13:00 -0000 [thread overview]
Message-ID: <87r2h2eq3f.fsf@tromey.com> (raw)
In-Reply-To: <87woquq3b7.fsf@redhat.com> (Sergio Durigan Junior's message of "Sat, 06 Oct 2018 15:32:12 -0400")
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> The patch looks good to me. My only question is about whether we still
Sergio> require a newline between variable declarations and the rest of the
Sergio> code. I still follow this rule (because I think it improves code
Sergio> readability), but now with C++11 I'm not sure if it's still being
Sergio> enforced.
I don't know, but I suppose so, and in any case I went ahead and added
it.
Tom
prev parent reply other threads:[~2018-10-06 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-06 19:20 Tom Tromey
2018-10-06 19:32 ` Sergio Durigan Junior
2018-10-06 21:13 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2h2eq3f.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox