From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40378 invoked by alias); 18 Oct 2018 22:16:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39851 invoked by uid 89); 18 Oct 2018 22:15:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=accommodate, Hx-spam-relays-external:sk:cm10.we, H*RU:100.42.49.4, Hx-spam-relays-external:100.42.49.4 X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Oct 2018 22:15:24 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 03B31400D7403 for ; Thu, 18 Oct 2018 17:15:09 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id DGZQgJCj4BcCXDGZQgZRTE; Thu, 18 Oct 2018 17:15:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=v3ik3LFrrCu85j1oJZNpuNRJGCzMXmsu4jDNT7KtFak=; b=Tfwlas0OtFZZGxFFQayCohzVoo Xh5+3c8TrrH07WNYHCA2AmQq++XOew+wVlcKniCYGYfQ0Yd2/TH7iNMi4IL7RLjGhSrkD5MVZS81/ IhC2YU2Kz2/LTYm9hVUt1dAa5; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:37606 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gDGZQ-002gXs-O0; Thu, 18 Oct 2018 17:15:08 -0500 From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [RFC 1/8] Change wrap buffering to use a std::string References: <20180906211303.11029-1-tom@tromey.com> <20180906211303.11029-2-tom@tromey.com> <9ac8cf66-040e-b11a-841b-4d378b256f8a@simark.ca> <87h8hwccyd.fsf@tromey.com> Date: Thu, 18 Oct 2018 22:16:00 -0000 In-Reply-To: <87h8hwccyd.fsf@tromey.com> (Tom Tromey's message of "Mon, 08 Oct 2018 16:04:26 -0600") Message-ID: <87r2gmaolw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00410.txt.bz2 >>>>> "Tom" == Tom Tromey writes: >>> To prevent this, change the wrap buffer to be a std::string and update >>> the various uses. Simon> This looks like a good change to me, independently of this series. I think you Simon> should push it right away. Tom> FWIW I think this patch will have to change to accommodate Windows -- or Tom> at least be totally obsoleted by the needed change. My plan is to have Tom> a vector holding strings with their styling. This has to happen because Tom> styling on Windows is done via an API, not via an escape sequence. I think I'm going to change plans here, due to my desire to also style source code in the TUI. GNU Source Highlight and Pygments both have ANSI terminal escape back ends. And, I already have code that can parse ANSI escapes and turn them into curses calls. My new plan for handling Windows is to generalize this ANSI escape parser and let it be specialized to emit console calls or whatever they are. Maybe I'll push this patch in independently after all... not sure yet. Tom