From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15135 invoked by alias); 21 Dec 2018 15:44:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15121 invoked by uid 89); 21 Dec 2018 15:44:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_RP_RNBL,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.133) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Dec 2018 15:44:31 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 476A64011E509 for ; Fri, 21 Dec 2018 09:44:30 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id aMyUg7Ktu4FKpaMyUgcNeG; Fri, 21 Dec 2018 09:44:30 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uVUeMPcQR4S9xBiiL91bwKMtCYknRamVxFICK9GMFV8=; b=u2Eog+mA2tpe4FGf6VNZuiV0ck 7stpseZSr79X4qZyHyYqCZ0fYndsmdVQ1G/HVKEib13kbvmavAK3KfvPQtom4jnS3LQTjHWPo+XTw opDiTfutlurJZb6kyexJiMWl7; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:57094 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gaMyT-002ftR-Si; Fri, 21 Dec 2018 09:44:30 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Tom Tromey , Simon Marchi , jimw@sifive.com, jhb@FreeBSD.org, palmer@sifive.com Subject: Re: [PATCHv2 1/4] gdb: Extend the comments in c-exp.y References: <55c3aab37c9193e6f8b999b19ddf9f30d917f042.1545172667.git.andrew.burgess@embecosm.com> Date: Fri, 21 Dec 2018 15:44:00 -0000 In-Reply-To: <55c3aab37c9193e6f8b999b19ddf9f30d917f042.1545172667.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Tue, 18 Dec 2018 22:40:10 +0000") Message-ID: <87r2easx43.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00247.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> In an attempt to fix PR gdb/13368 this commit adds some comments to Andrew> c-exp.y which hopefully makes the type parsing code a little clearer. Andrew> There are no code changes here, so there should be no user visible Andrew> changes after this commit. Andrew> gdb/ChangeLog: Andrew> PR gdb/13368 Andrew> * c-exp.y (typebase): Extend the comment. Andrew> (ident_tokens): Likewise. Thanks, this is ok. Tom