From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87010 invoked by alias); 28 Dec 2018 20:57:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86997 invoked by uid 89); 28 Dec 2018 20:57:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=alien, Source, enjoy X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (50.116.125.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Dec 2018 20:57:17 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 22B80400C5ACE for ; Fri, 28 Dec 2018 14:08:39 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id czBzgv5cIYTGMczBzgifvC; Fri, 28 Dec 2018 14:57:15 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/8kmwRnxGYP6HpoYsZiLqf5Ad2wzejlznhdtayfzuGU=; b=kcMQ1iPgxH10PLGWA/747taZkM IiHRfr2OYjcOwvvzM88fDoidFjLcv3O2Phb+4OnH8rHHGmINj8ZQG46iTvHLJwDS0k/JRYR19OJ+U ODEHJ3OVUodaQJ5nLuB5EcFTA; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:34648 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gczBz-001GB3-K2; Fri, 28 Dec 2018 14:57:15 -0600 From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 00/16] Add styling to the gdb CLI and TUI References: <20181128001435.12703-1-tom@tromey.com> <20181224092735.GL5246@adacore.com> Date: Fri, 28 Dec 2018 20:57:00 -0000 In-Reply-To: <20181224092735.GL5246@adacore.com> (Joel Brobecker's message of "Mon, 24 Dec 2018 13:27:35 +0400") Message-ID: <87r2e1mkt1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00396.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> I gave the whole series a look. The TUI changes were a bit alien Joel> to me. I sent comments on the patches where I had questions; Joel> otherwise, those I didn't comment on looked fine to me. Thanks for the reviews! Joel> One feature I might volunteer to work on once the series is in Joel> is to provide two sets of defaults for the colors - one to be used Joel> when the terminal has a dark background vs one to be used when Joel> the terminal has a light background. I think the way ou added Joel> colorizing should make it easy to do. This sounds like a good idea, and we can certainly tinker with it as need be. I have a few patches to GNU Source Highlight that I am trying to get in. I have some updates for the C and C++ support, plus Rust support. The project seems a bit dead so I've asked maintainers@gnu to give me permissions to check in some patches and do a new release. Joel> That's all I had to say as a summary. Thanks a lot for those. Joel> I think people are going to enjoy this enchancement. At least Joel> I know I will! Thanks. I am going to check in the series now. Tom