From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 649 invoked by alias); 29 Mar 2019 15:03:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 634 invoked by uid 89); 29 Mar 2019 15:03:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:745, H*f:sk:D0495ED, H*i:sk:6B4C380, indented X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 29 Mar 2019 15:03:06 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway32.websitewelcome.com (Postfix) with ESMTP id B0C801A29F for ; Fri, 29 Mar 2019 10:03:04 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9t27hAj5d2qH79t27ha3Cj; Fri, 29 Mar 2019 10:03:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WrnWo+ESBd4MK8x+a1s8QIXUQEAo2w555/ivIqFSrqk=; b=VWOXsQq03bClsgkZEZVmhMM7HO wJFOy2tiXtGZIumJu2Gyqp2N4W0IiOsGDgf9MrGJkKo6eKKFm2O8MQsDaUjw0BfY8HnFo1udiQ+wt vlXWaLocDiOMsQt9UGDa0T5uO; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:44692 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h9t27-0030D9-8C; Fri, 29 Mar 2019 10:03:03 -0500 From: Tom Tromey To: Marco Barisione Cc: Tom Tromey , Kevin Buettner , gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: [PATCH v4] Add gdb.Value.format_string () References: <20190317135023.2e51944d@f29-4.lan> <20190318093441.641ca394@f29-4.lan> <0905920C-D564-4505-B42E-522F1BB95397@undo.io> <874l7om5sh.fsf@tromey.com> <6B4C3808-7D1A-46E2-A4B4-50186779B9B0@undo.io> Date: Fri, 29 Mar 2019 15:03:00 -0000 In-Reply-To: <6B4C3808-7D1A-46E2-A4B4-50186779B9B0@undo.io> (Marco Barisione's message of "Thu, 28 Mar 2019 13:54:57 +0000") Message-ID: <87r2apk9jt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-03/txt/msg00745.txt.bz2 Marco> I=E2=80=99ve attached a patch which is identical to the previous one= except for: Thanks. Do you have a copyright assignment? I see you aren't in MAINTAINERS, so I presume you don't have write access. Contact me off list and we can set that up. Marco> I=E2=80=99ve done this and indented the braces by two spaces and the= array=E2=80=99s Marco> content by another two spaces. Marco> This seems to match my understanding of the GNU/GDB indentation styl= e, but Marco> I=E2=80=99m not 100% sure it=E2=80=99s the correct one as, in other = places in the code Marco> base, this kind of brace is not indented. Yeah, I think that's the rule for braces, but it wasn't consistently followed for array initializers in the past. Tom