From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115751 invoked by alias); 20 Aug 2019 20:22:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115743 invoked by uid 89); 20 Aug 2019 20:22:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.218) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Aug 2019 20:22:55 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 656FF11449 for ; Tue, 20 Aug 2019 15:22:54 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 0AeciYDYL4FKp0Aecidu3S; Tue, 20 Aug 2019 15:22:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PiVanqWt+DEI62fqUizg8LAhsqM1nLAk7pYXgkYNpkQ=; b=xc4VKhGZlQmhyXGRn1cpDLj3eS PHnvaejWDf9FU0lVfYjXhalklwyesYJjCQWa7nb06BkAmOqV/QNVcMt7VhZNBg68rt+iOxWDYpS9/ Rdk2cMqPOS08wAWvTZrM4qq1n; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:58354 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i0Aec-0048Bf-4T; Tue, 20 Aug 2019 15:22:54 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: Move gdbsupport to the top level References: <87lfx4z3lx.fsf@tromey.com> <2c6c79e9-8a36-6b35-67f4-5cf92f03f8db@redhat.com> Date: Tue, 20 Aug 2019 20:22:00 -0000 In-Reply-To: <2c6c79e9-8a36-6b35-67f4-5cf92f03f8db@redhat.com> (Pedro Alves's message of "Tue, 20 Aug 2019 20:38:11 +0100") Message-ID: <87r25fmvs2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00434.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> (I'm looking at the branch, so I'm not sure I'm commenting on the patch Pedro> as it was posted.) I think I made a few changes based on reviews, though I don't fully recall. Pedro> This all builds fine for me when I build normally, but, Pedro> this breaks building gdbserver standalone, without configuring Pedro> from the top level. I.e.: I will take a look. Meanwhile you should also look at this: https://sourceware.org/ml/gdb-patches/2019-08/msg00053.html ... because I think that's another blocker to this project. That message neglected option 4, which is removing readline from the tree. (But making it continue to work if the sources are dropped in, as we already do for libiconv etc.) Pedro> What are the new rules here? Add on as-needed basis, Pedro> or should we have some nat.h file that is included by Pedro> all nat/ files, and same for arch/ ? The former seems a bit Pedro> error prone, given that you could move code around and not realize Pedro> that an #ifdef is disabling something because you missed config.h. Pedro> Alternatively, I guess we could move the required bits from Pedro> gdb&gdbserver's configury to gdbsupport's, so that config.h Pedro> wasn't ever necessary in shared code. Not sure whether that Pedro> would be a bit of an abstraction violation. Yeah, I just did what was needed to make it work, but I didn't really come up with a long-term plan. Maybe moving nat and arch to gdbsupport is the another option? That would require some #include adjuments but otherwise maybe it's not such a big deal. Tom