From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17068 invoked by alias); 30 Sep 2019 16:22:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17060 invoked by uid 89); 30 Sep 2019 16:22:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:648 X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.63.14) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Sep 2019 16:22:43 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 07025400E9CC7 for ; Mon, 30 Sep 2019 10:16:00 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id EyRei0RzKOdBHEyReiV5Tx; Mon, 30 Sep 2019 11:22:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iHUUpvS/9jluoEIHyWDlWqPLPwdWmliqrKNxQK1tSHc=; b=VUtnyyYxnzhaeFZSLIWylQHZnK Y0r2T70dkcHNs53VVcvAJZhI6A82LeXuGy7rtAu3qWU59clUadhWpNiU7YJXGRwDuKyokL+/T5kWP lBmDHXFESAFEMru3xrgouopJY; Received: from 75-166-72-156.hlrn.qwest.net ([75.166.72.156]:34814 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iEyRd-001cxi-Mh; Mon, 30 Sep 2019 10:22:41 -0600 From: Tom Tromey To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] OpenMP parallel region scope tests References: <20190822171408.28271-1-kevinb@redhat.com> <20190822171408.28271-3-kevinb@redhat.com> Date: Mon, 30 Sep 2019 16:22:00 -0000 In-Reply-To: <20190822171408.28271-3-kevinb@redhat.com> (Kevin Buettner's message of "Thu, 22 Aug 2019 10:14:08 -0700") Message-ID: <87r23xah4f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00616.txt.bz2 >>>>> "Kevin" == Kevin Buettner writes: Kevin> Add tests which check for accessibility of variables from within Kevin> various OpenMP parallel regions. I don't know anything about OpenMP, so I didn't read new .c file. I'm not especially concerned about it though. Kevin> +if {[gdb_compile_openmp "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != ""} { Over-long line. Kevin> +if {[info procs openmp_setup] != ""} { Kevin> + if {[openmp_setup $binfile] != ""} { Kevin> + return -1 Does this need a call to "untested"? The rest seemed fine to me. Tom