Re: [PATCH] Fix assertion fi->level

[Tom Tromey <tom@tromey.com>]

>>>>> "Mark" == Mark Williams <mark@myosotissp.com> writes:

Mark> Apparently I should ping the thread after 2 weeks with no response...

Yeah.

Mark> Note that python unwinders are completely unusable in gdb-8.1 and
Mark> later without this fix...

Thanks.

I read the patch, and I think it looks reasonable.  However, since we
were considering it for gdb 9 in another thread, I applied it and ran
the test suite.  It caused a few regressions, like:

gdb.base/jit-reader.exp: with jit-reader: after mangling: caller frame: cannot a
ssign to register: PASS => FAIL
gdb.mi/mi-reg-undefined.exp: register values, format r, frame 1: PASS => FAIL
gdb.mi/mi-reg-undefined.exp: register values, format r, frame 2: PASS => FAIL
gdb.mi/mi-reg-undefined.exp: register values, format x, frame 1: PASS => FAIL
gdb.mi/mi-reg-undefined.exp: register values, format x, frame 2: PASS => FAIL


Here's some stuff from gdb.log:

me: print pseudo register
print $rbp = -1
Left operand of assignment is not an lvalue.
(gdb) FAIL: gdb.base/jit-reader.exp: with jit-reader: after mangling: caller frame: cannot assign to register


221-data-list-register-values --thread 1 --frame 1 x  0 1 2 8 9
~"../../binutils-gdb/gdb/value.c:389: internal-error: int value_bits_any_optimiz
ed_out(const value*, int, int): Assertion `!value->lazy' failed.\nA problem inte
rnal to GDB has been detected,\nfurther debugging may prove unreliable.\nQuit th
is debugging session? (y or n) "
FAIL: gdb.mi/mi-reg-undefined.exp: register values, format x, frame 1 (timeout)


I didn't investigate any further but there's still some issue to be
worked out.

thanks,
Tom