Re: [PATCH 11/14] Split type_unit_group

Tom Tromey
2020-02-22T00:40:13Z

>>>>> "Luis" == Luis Machado <luis.machado@linaro.org> writes:

>> + /* The symbol tables for this TU (obtained from the files listed in
>> + DW_AT_stmt_list).
>> + WARNING: The order of entries here must match the order of entries
>> + in the line header. After the first TU using this type_unit_group, the
>> + line header for the subsequent TUs is recreated from this. This is done
>> + because we need to use the same symtabs for each TU using the same
>> + DW_AT_stmt_list value. Also note that symtabs may be repeated here,
>> + there's no guarantee the line header doesn't have duplicate entries. */

Luis> Does something need to be adjusted in the comments for "struct
Luis> type_unit_unshareable" now that we've split these fields from the
Luis> bigger type_unit_group struct?

I think this all remained the same.

Tom