Re: [PATCH 00/14] Share DWARF partial symtabs between objfiles

Tom Tromey
2020-02-23T23:58:20Z

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> I think it would be more natural and easier to understand to have :

Simon> objfile -> dwarf2 objfile-specific object -> dwarf2 object shared between objfiles

Simon> Many "dwarf2 objfile-specific" objects would point to one "dwarf2 object shared between
Simon> objfiles", without special tricks. Of course, it's much easier said than done.

Simon> I'd like to know: did you consider this way of doing it and chose not to do it
Simon> because of the complexity / size of the change? Is the current patchset a stepping
Simon> stone towards it?

I was afraid of the size of the resulting patch. However, I think
you're right that this would be better. And, I feel pretty strongly
that we should be making the DWARF reader less awful, not more.

Probably the thing to do is reorder the series a little (some patches
don't depend on this), then redo the "unsharing" patch, and finally
update the subsequent patches.

A few of these patches (1-3, 5, and 11) could probably go in sooner.
What do you think of that?

Tom