From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway30.websitewelcome.com (gateway30.websitewelcome.com [192.185.149.4]) by sourceware.org (Postfix) with ESMTPS id B6C86385DC00 for ; Mon, 30 Mar 2020 23:53:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B6C86385DC00 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 4EBDC262B6 for ; Mon, 30 Mar 2020 18:53:45 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id J4DxjDAw5Sl8qJ4DxjjMtk; Mon, 30 Mar 2020 18:53:45 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=w9hNrkvfLKW5rHHNRjsCmWvgmg3vu2nFfA9U2c165hs=; b=QmmmtKh+g/SLekRWURTglWhbDk p6u8rmLFVunD3rIlgiMEgZFGnSn4cV0SsbztoLPQodtYxWWMHIAK2K41C9OLFlF1n2Ig3+j7c3vXl VsEUazxYk1zIUuTepNwROfVEK; Received: from 97-118-117-21.hlrn.qwest.net ([97.118.117.21]:57086 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jJ4Dx-002uZo-2J; Mon, 30 Mar 2020 17:53:45 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 04/20] Change some uses of DW_STRING to string method References: <20200328192208.11324-1-tom@tromey.com> <20200328192208.11324-5-tom@tromey.com> X-Attribution: Tom Date: Mon, 30 Mar 2020 17:53:44 -0600 In-Reply-To: (Simon Marchi's message of "Mon, 30 Mar 2020 10:56:58 -0400") Message-ID: <87r1x9xuuv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.117.21 X-Source-L: No X-Exim-ID: 1jJ4Dx-002uZo-2J X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-117-21.hlrn.qwest.net (bapiya) [97.118.117.21]:57086 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2020 23:53:47 -0000 >>>>> "Simon" == Simon Marchi writes: Simon> In cases like this, I think it would be worth assigning the result of attr->string Simon> to a local variable, to avoid paying the cost of the check multiple times Simon> unnecessarily. I made this change. I did some profiling of the DWARF reader recently and I think that some of these methods should probably be inlined as well. I'll double-check ... my profiling was on a branch without this series, but inlining form_is_ref and part of get_ref_die_offset was a win. Tom