From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway30.websitewelcome.com (gateway30.websitewelcome.com [192.185.168.15]) by sourceware.org (Postfix) with ESMTPS id 87CFE3858D35 for ; Tue, 30 Jun 2020 20:55:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 87CFE3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 3094873D6 for ; Tue, 30 Jun 2020 15:55:23 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id qNHnjlyyjSxZVqNHnjpasu; Tue, 30 Jun 2020 15:55:23 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bHfelZgAhzu4Va6j0hD7fJc66n2/VzY6ZuFeWOh4qsI=; b=Cgz24O8F2H1xgkw1B2rSsX/rYr sOd15ZDP+GhX1QxCIh6LdfXOuJQx+41N8N/vALJCjgWm7/vRMF6mXoWU3B87i4LN7uo0Ri+3DGaEz 9upCV8Lgfh67hnftaRUL8SpSq; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:45952 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jqNHm-004CBh-UD; Tue, 30 Jun 2020 14:55:23 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH 3/3] gdb: make macro_stringify return a gdb::unique_xmalloc_ptr References: <20200628165628.96730-1-simon.marchi@polymtl.ca> <20200628165628.96730-4-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Tue, 30 Jun 2020 14:55:22 -0600 In-Reply-To: <20200628165628.96730-4-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Sun, 28 Jun 2020 12:56:28 -0400") Message-ID: <87r1tw8e9x.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jqNHm-004CBh-UD X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:45952 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jun 2020 20:55:25 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> The change to macro_stringify is straightforward. This allows removing Simon> the manual memory management in fixup_definition. Simon> @@ -882,25 +882,19 @@ macro_undef (struct macro_source_file *source, int line, Simon> static struct macro_definition * Simon> fixup_definition (const char *filename, int line, struct macro_definition *def) Simon> { Simon> - static char *saved_expansion; [...] Simon> + gdb::unique_xmalloc_ptr saved_expansion; This loses the "static", but that's necessary because this function returns "def", which has a pointer to the contents. Tom