From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KrcJFVKvIWDnSwAAWB0awg (envelope-from ) for ; Mon, 08 Feb 2021 16:38:26 -0500 Received: by simark.ca (Postfix, from userid 112) id 3BFCF1EF4F; Mon, 8 Feb 2021 16:38:26 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D27021E4A3 for ; Mon, 8 Feb 2021 16:38:25 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7A3233898539; Mon, 8 Feb 2021 21:38:25 +0000 (GMT) Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.49.218]) by sourceware.org (Postfix) with ESMTPS id 991B53896C2D for ; Mon, 8 Feb 2021 21:38:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 991B53896C2D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 819895A0BA for ; Mon, 8 Feb 2021 15:38:18 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9EEclcRNjDT649EEclQkjq; Mon, 08 Feb 2021 15:38:18 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=j78ySNHqgiRCex6T1Be2qqyTKUWtJ9usP8ATlGl+JCk=; b=PMXOvWhnAZml6m/xIT0ysn7UcW lxHwHOWVts2KUCHjmLdLaUm9S/m7MApkK+OqntaIc1Fs0hOSxuLSd6jFrx6XeVAp9hYJQUTayCtBd V30MHFJca0u5t2B8fP1ZiUpC0; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:38422 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l9EEb-003HtD-SB; Mon, 08 Feb 2021 14:38:17 -0700 From: Tom Tromey To: Zoran Zaric via Gdb-patches Subject: Re: [PATCH 14/30] Simplify dwarf_expr_context class interface References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-15-Zoran.Zaric@amd.com> X-Attribution: Tom Date: Mon, 08 Feb 2021 14:38:17 -0700 In-Reply-To: <20201207190031.13341-15-Zoran.Zaric@amd.com> (Zoran Zaric via Gdb-patches's message of "Mon, 7 Dec 2020 19:00:15 +0000") Message-ID: <87r1lqdyuu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l9EEb-003HtD-SB X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:38422 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Zoran" == Zoran Zaric via Gdb-patches writes: Zoran> The eval_exp method is the method that evaluates a DWARF expression Zoran> and provides the evaluation result, in a form of a single struct Zoran> value object that describes a location. How about just calling this method "evaluate"? Same length, but no abbreviations. Otherwise this looks good to me. Tom