From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yDv8JizjnmC9JwAAWB0awg (envelope-from ) for ; Fri, 14 May 2021 16:53:00 -0400 Received: by simark.ca (Postfix, from userid 112) id 907D01F11C; Fri, 14 May 2021 16:53:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6671D1E783 for ; Fri, 14 May 2021 16:52:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C04453854814; Fri, 14 May 2021 20:52:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C04453854814 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1621025578; bh=N7D2KUGsx2SQvjxfWELzOxuqhxjjZUMhR8aIwGZT01s=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=SQEr0aMWiQhUv9uK65KikAElKFEZyjn+YV4z7rIrNN/rvqV+lNGcYyqUyHMocDNiv JEZXU3PXy/4jgx3MVBv71ACrBr5YJeF1w/0B6Pbj7UQ8uTkd9tp629I757aarXftCj V3hGYGRdcRQNq4mhB/4KAlnVskNCl3eJ/opvs/q8= Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by sourceware.org (Postfix) with ESMTPS id 9AFB9385BF9D for ; Fri, 14 May 2021 20:52:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9AFB9385BF9D Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14EKmvdg013190; Fri, 14 May 2021 20:52:54 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 38gpnxwavr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 May 2021 20:52:54 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14EKnqCV075937; Fri, 14 May 2021 20:52:53 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2109.outbound.protection.outlook.com [104.47.55.109]) by userp3030.oracle.com with ESMTP id 38gpq3e2yy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 May 2021 20:52:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tvz21E50zTb560EXDGKKlFOofmvGcbzoPpNA84V4i7hC+APiqakzMlxojEUR8m+o9St/R4bNgUO21UPP5x5dvzT9C1iXIUnX1smWU5RNQFzA0Bk8RlA9+a0zU0HUAdCTe5jvBJ+aojBlIA66M3/EZmcgAAwcsgXhQg635IVs7V95j7ZFzD9S2Lbqsb6OAcLupiDeh33grlRfDVCakdSYt31G9hzfnoA/snV2rTZg7zjCN6m2UM0mhsoi9TaNzRle1hxkkMVyQM7c8ZzTPhwSq5FkkXGQpATIo3mvy/YIwluMZkUz2mujVfw1d3at07BUAC7RHZLHWXY0Cr98oRrjkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N7D2KUGsx2SQvjxfWELzOxuqhxjjZUMhR8aIwGZT01s=; b=Nn2a9zZ3HJrYfzXJnNLODX1FzoXCh+ySwvdqbeQrBzhNYYB8XcDEwP/zJWHpKrcV0sYLxmHPFDbASqDqhp0ANp4m6EoL7GyQ2x/Qi0uihVhhS+CG3VtZ1/rhsGVsIPs4sGuIQvSFtU528/kEoH4/XSIreoGNyKp8TiE+2ps+P9LrvWxqHqmreSkd0t/wRh10WiNBDR0C8z3VqtQMmg9JwwE09rWmZkwpWlpvEJq1+1lgKQnmcUch9MlVpd04GBX3O+xVgURNCFjvvgaN8uSPmXzudH5BV02dF3+a2F46KCKD++FxcfFYxeQSYMlaIc9rMFsOne/IFd9r0dffpLxX+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from DM5PR10MB2041.namprd10.prod.outlook.com (2603:10b6:3:111::16) by DS7PR10MB4863.namprd10.prod.outlook.com (2603:10b6:5:297::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.28; Fri, 14 May 2021 20:52:51 +0000 Received: from DM5PR10MB2041.namprd10.prod.outlook.com ([fe80::14a9:31e9:48af:5e4f]) by DM5PR10MB2041.namprd10.prod.outlook.com ([fe80::14a9:31e9:48af:5e4f%8]) with mapi id 15.20.4129.026; Fri, 14 May 2021 20:52:51 +0000 To: Tom Tromey Subject: Re: [PATCH 0/1] Integrate GNU poke in GDB References: <20210510151044.20829-1-jose.marchesi@oracle.com> <87k0o56qvz.fsf@tromey.com> <87bl9gnzpe.fsf@oracle.com> <875yzm6373.fsf@tromey.com> Date: Fri, 14 May 2021 22:52:40 +0200 In-Reply-To: <875yzm6373.fsf@tromey.com> (Tom Tromey's message of "Thu, 13 May 2021 09:52:48 -0600") Message-ID: <87r1i911if.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-Originating-IP: [89.204.138.71] X-ClientProxiedBy: PR3P189CA0077.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:b4::22) To DM5PR10MB2041.namprd10.prod.outlook.com (2603:10b6:3:111::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from termi.oracle.com (89.204.138.71) by PR3P189CA0077.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:b4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.32 via Frontend Transport; Fri, 14 May 2021 20:52:50 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 643e7f4d-d184-4071-38e8-08d9171a3d1d X-MS-TrafficTypeDiagnostic: DS7PR10MB4863: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1oAqfhFZmwb7fEfNYI6OcekT9JhTqD2jmQ+WMHRO36caBpRRMExqCS7Ev4tsq5q4Sr+EWHa7ByStq/vgkCwdC7KtiqyzUtU5W0+Ld/x+cscdWo4IhPEDFn+jX3eaZlo8LDOc42qH/MDM22b6OkHJvGqG4I+TIDUjye97iyKWk2jccJK2yk1xrngplDSe0Pe4qyXyLR6jFnwQVRlMOLDCuCKZBkfuY3BRC60nzbTYwQN5kqVYzKTpH2OT3kc1T4/sWDT/h4ior2PyckaAzj6Mz2PBL+SnrkboGJy6vDPvnHqOde0/0Hf/0UDjv/U9jFp8GQvvcC/ByTqRuzADBNIEM9jhm27LhZr+ma/IKSYZe53jhltvFNCWd8I6aJqfDrwC7bj6940eTFbDiOAEq6WSBAYNBtP9uFbiDxxM3ohIDGiohbMK6iZRmMuNrCS+MS9v+jwIaSdSaPIO1Ib8/Pj5dvd4T/Q9bYpeoASuHqujBQ/xNzx1c6Y1Mz9zK4HR39P4oxltVF1jzOZt9oW2sHgr+OAvaeZpHrAvmuxK32pAolPLoNw9rokvtlkdkFpkrKxgyxp8CIXD4a07xfuZ/y7qmhfZstn7aOQ07vw0Out2K0xKUClpVuTtWFWB7NoPodsdNnwy58pZoEtp5x6D2rrd9w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR10MB2041.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(39860400002)(136003)(396003)(346002)(376002)(956004)(6666004)(478600001)(26005)(8676002)(7696005)(66556008)(66476007)(66946007)(2906002)(52116002)(16526019)(186003)(316002)(6916009)(8936002)(38350700002)(38100700002)(6486002)(4326008)(2616005)(83380400001)(5660300002)(36756003)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?klXymHDsQNebNus07wQ/ZQZLxROMYrxKixX3Hm5hnK611k2chiJdxj1oR4VV?= =?us-ascii?Q?KgkoE/9pX8TSDotaZZbuMhvZvWDUw9OVGOX3MTX9qBXD6X1qtbtrL2T4AGE8?= =?us-ascii?Q?1MDWBcY5Ayss11s3IkVnuSerE6tjTH+hQV7f955CN87F+t25wJc+ThDf+uA+?= =?us-ascii?Q?DhPhqVUDCizRZ0fvlxGpedTPoX6hkr+G612GEo1UB0p33EnX/D/cBfw7Cdsv?= =?us-ascii?Q?xji8KZswtRXtyeY6ALB0u5qTVrNhXeSkWJRGXthgmZ8VAVIclZ5q1LQ8cWu2?= =?us-ascii?Q?admPv+kv8mgGZ8XIfOrId4vIEzc7TJM6Tq1BxafYRZ/2sNgfMWVlWyL8B/kZ?= =?us-ascii?Q?SCCTC+kDT/DHfZaf6FwYid2srTapU9/F1F0ixk8wy+TlJYHRe16IlrmWHpmP?= =?us-ascii?Q?w1xBqITR0qQKcNbWvSEmMxIzELHIvnmBt4bukyS80WwCzdDkZul1rUZuhiUp?= =?us-ascii?Q?wmGM/dYuD5rMVVkwEi9Tw6A9m6+oVkN5t9TQ9+BdOIGJKXDPkrf3nmfB8AW5?= =?us-ascii?Q?UR651Ka0q1iZVkYK3D9iU8K9j9Qo8P/zqj7umToEQjk0P8GsiMfkVsuDHBEV?= =?us-ascii?Q?GnHCOEQLzW5Pf0m3+3FGAu4w6qnQX+2pRXioyhA16l6npC5Vo74wEDI4xc3S?= =?us-ascii?Q?N7DHUg28NuSQGDUNT9sSfD2hOyZxUjypEgvJBvYVyjaLgUhLPM6plY/LNWly?= =?us-ascii?Q?taCu0OJIfOG01sg4U5cO+DcsT/aXy20POKo3chHyEmZ99UbemGRbr6kNHkak?= =?us-ascii?Q?alUwDbEtBgd5Yjj9g1ihr5J517oBRjf8ZfS0r5ysQHGDGaCwvwBuS482BDGT?= =?us-ascii?Q?HAnSCdl6Yvxz3laQZ0EBTYC4K962uV3drN0YCsSrgESqj0zt95NKyOK8nO2q?= =?us-ascii?Q?haaLY8nPs0GvVcNmVTqj5i8d6sV1nhK31I6yLVcs295bO+YX31XwHMY0usEm?= =?us-ascii?Q?69bGXwLaG2f+6UbBcITmSbFT+rW1O+YeIqqAXY+MfInOErHoYil87E/99B76?= =?us-ascii?Q?LMDZa8XQv+Kf64vv0RTrKAO1Cns/THxV1K2yNUvy4x1Yq0u1SSrJ4xlNXO5R?= =?us-ascii?Q?yHmZtHvWO1Eds8bUU71awD/V7JaIhtDv0E0EebDQaqlQgCHOPqMSkcGgcpDx?= =?us-ascii?Q?rDF6Z28c76Jl0+7ADxveDK+MZHoq16l8JpbDHQa39j18morW46270H0r2La2?= =?us-ascii?Q?QiJb7oERooVrCv7MSFwhOM4mJJxzCNE1V6V1AhFWI16POlkRbRcf4Cn7ZmNC?= =?us-ascii?Q?64ILVjRnPhzPu22ZKia84NJlNJWLxa90JNhho0jAaxD8iZDVUgeyc6o7dMut?= =?us-ascii?Q?Oheh6GzD5GUyUjqJwS7rQRWh?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 643e7f4d-d184-4071-38e8-08d9171a3d1d X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB2041.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2021 20:52:51.3568 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x4CibpoJWxxYcPEgh9I0PtidFGVmyJIMw/NITl9U24jcOjfVDdtSX3LbK1FXijwNC5U6oF02ZZSmNi2aYSXGpMse35gB20fPMTFmO0zF0oU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4863 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9984 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 malwarescore=0 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105140166 X-Proofpoint-GUID: TyBD9fxTYRX9u2DvJiGqoW677OtZdSKW X-Proofpoint-ORIG-GUID: TyBD9fxTYRX9u2DvJiGqoW677OtZdSKW X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9984 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 bulkscore=0 adultscore=0 priorityscore=1501 phishscore=0 malwarescore=0 spamscore=0 impostorscore=0 mlxlogscore=999 mlxscore=0 clxscore=1015 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105140166 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Jose E. Marchesi via Gdb-patches" Reply-To: "Jose E. Marchesi" Cc: "Jose E. Marchesi via Gdb-patches" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>>> "Jose" == Jose E Marchesi via Gdb-patches writes: > > Jose> poke STR > Jose> poke-add-type EXPR > Jose> poke-add-types REGEXP > Jose> poke-dump-types > >>> It's maybe more gdb-ish to make one command and use subcommands. > > Jose> What would be the gdb-ish way: > > Jose> a) poke STR > Jose> poke add-type EXPR > Jose> poke add-types REGEXP > Jose> poke dump-types > > Jose> or > > Jose> b) poke STR > Jose> poke add type EXPR > Jose> poke add types REGEXP > Jose> poke dump types > > Jose> Because a) will be problematic: `add-types' can be a valid Poke > Jose> expression if both `add' and `types' are defined as variables. > > Jose> Doing b) would be ok I think. > > Either is fine, though (b) is more of a pain to implement. If the plain > prefix command is ambiguous, you can have it work like "set", where "set X" > evaluates X, but "set var" is a subcommand to avoid the ambiguous case. Ok, I will go with a) using that strategy. > Jose> But I am not really looking forward to write Python bindings for libpoke > Jose> (or Python for anything for that matter) and even if I could recruit > Jose> someone to do that work, the stuff would need to be maintained ... poke > Jose> depending on Python, supporting future Python versions and what not, > Jose> argh no no no no :) > > Just to be clear, gdb often has a high burden to get a patch in. That's pefectly fine. I have contributed to GDB before. > For example, do you have a gdb copyright assignment in place? We can't > accept your patch until that's done. I can contribute it under my employer's assignment. I will sign a personal assignment for GDB anyway; I looked in fencepost and I don't have one in place. It is super fast and easy to do so nowadays using PDF documents (at least from Germany.) Thanks!