From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [master + 11][gdb/build] Disable attribute nonnull
Date: Thu, 29 Jul 2021 11:30:54 -0600 [thread overview]
Message-ID: <87r1fhauy9.fsf@tromey.com> (raw)
In-Reply-To: <d33e7941-abc0-d371-6f66-62388d602c01@suse.de> (Tom de Vries's message of "Thu, 29 Jul 2021 13:42:15 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> The current conclusion is that it's best to disable this. This is explained
Tom> at length in the gdbsupport/common-defs.h comment.
FWIW this looks reasonable to me.
I would recommend waiting a little to see if anyone else disagrees.
Normally I'd say let's simply not use ATTRIBUTE_NONNULL, but one thing I
like about your approach is that it provides a spot to put this great
comment you wrote.
Tom
next prev parent reply other threads:[~2021-07-29 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210726211101.ivychvbfgaafxjtz@lug-owl.de>
[not found] ` <20210727100354.GB4037238@embecosm.com>
[not found] ` <b29d9d0b-f847-c0a0-9f09-d42d0f5e91df@suse.de>
[not found] ` <20210727113511.GC4037238@embecosm.com>
[not found] ` <6cf80ba9-b010-bb42-c92d-84e4f396813c@suse.de>
[not found] ` <b4da20e9-69a0-8b92-606d-ddf858539a66@suse.de>
2021-07-27 16:28 ` [gdb/build] Fix Werror=nonnull-compare build breaker with gcc 12 Tom de Vries
2021-07-28 9:28 ` Andrew Burgess
2021-07-28 15:31 ` Tom de Vries
2021-07-28 16:15 ` Tom Tromey
2021-07-28 22:32 ` Tom de Vries
2021-07-29 11:42 ` [master + 11][gdb/build] Disable attribute nonnull Tom de Vries
2021-07-29 17:30 ` Tom Tromey [this message]
2021-07-30 10:16 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1fhauy9.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox